chore(sdk): improve usability TxType trait
#12548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
emhane
requested review from
Rjected,
joshieDo,
mattsse,
fgimenez and
gakonst
as code owners
mattsse
approved these changes
Nov 15, 2024
Comment on lines
+33
to
+46
| /// Returns `true` if this is a legacy transaction. | ||
| fn is_legacy(&self) -> bool; | ||
|
|
||
| impl<T> TxType for T where | ||
| T: Send | ||
| + Sync | ||
| + Unpin | ||
| + Clone | ||
| + Copy | ||
| + Default | ||
| + fmt::Debug | ||
| + fmt::Display | ||
| + PartialEq | ||
| + Eq | ||
| + PartialEq<u8> | ||
| + Into<u8> | ||
| + Into<U8> | ||
| + TryFrom<u8, Error: fmt::Debug> | ||
| + TryFrom<u64, Error: fmt::Debug> | ||
| + TryFrom<U64> | ||
| + alloy_rlp::Encodable | ||
| + alloy_rlp::Decodable | ||
| { | ||
| /// Returns `true` if this is an eip-2930 transaction. | ||
| fn is_eip2930(&self) -> bool; | ||
|
|
||
| /// Returns `true` if this is an eip-1559 transaction. | ||
| fn is_eip1559(&self) -> bool; | ||
|
|
||
| /// Returns `true` if this is an eip-4844 transaction. | ||
| fn is_eip4844(&self) -> bool; | ||
|
|
||
| /// Returns `true` if this is an eip-7702 transaction. | ||
| fn is_eip7702(&self) -> bool; |
There was a problem hiding this comment.
actually not sure if we call these on the txtype itself, we def call them on the tx.
so I assume we could upstream these to alloy, probably as a standalone new trait
There was a problem hiding this comment.
we have match statements on TxType, which these would replace. Agree that they should be added to the tx trait too, along with the useful as_eipX -> Option<&tx> methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #12454