Changes to TNeonDeserializerJSON.ReadArray to repair MemoryLeak to Array Class

[Stefan1286b]

Hello.
I have some changes to TNeonDeserializerJSON.ReadArray
When I have an Object to deserialize which has a field that is an ARRAY OF (Class inherited from TObject) then in the actual Version.
The inherited objects are removed from the array but not freed. And new inherited Objects are created.
That a Memory Leak.
There is a comment

  // We don't need to free items (objects) because the array to deserialize
  // to is always a new value
  // TRttiUtils.FreeArrayItems(AData);

But I don't underständ why we don't need to free it.

I have change it in my version, it will only free if Config.AutoCreate and the JSON Array is smaller then the object array.
If Config.AutoCreate and JSON Array is greater then the Object Array grow up und the Object will be automaically created by:
ReadDataMember(LItemParam, LItemValue, True) -> ReadReference(AParam, AData) -> ManageInstance(AParam.JSONValue, AData, AParam.NeonObject) -> TRttiUtils.CreateInstance(LType)

I tested some situations and all works fine.

Here is my code:

function TNeonDeserializerJSON.ReadArray(const AParam: TNeonDeserializerParam; const AData: TValue): TValue;
var
  LIndex: NativeInt;
  LArrayLength: NativeInt;
  LJSONArray: TJSONArray;
  LItemValue: TValue;
  LItemParam: TNeonDeserializerParam;
begin
  if AParam.JSONValue is TJSONNull then
    Exit(TValue.Empty);

  Result := AData;
  LJSONArray := AParam.JSONValue as TJSONArray;
  LArrayLength := LJSONArray.Count;

  if AParam.RttiType.TypeKind = tkArray then
    LItemParam.RttiType := (AParam.RttiType as TRttiArrayType).ElementType
  else //tkDynArray
  begin
    LItemParam.RttiType := (AParam.RttiType as TRttiDynamicArrayType).ElementType;
    if (LJSONArray.Count <> AData.GetArrayLength) then
      if LItemParam.RttiType.TypeKind = tkClass then
      begin
        If (FConfig.AutoCreate or AParam.NeonObject.NeonAutoCreate) then
        begin
          for LIndex := LJSONArray.Count to AData.GetArrayLength - 1 do
          begin
            LItemValue := AData.GetArrayElement(LIndex);
            if LItemValue.IsObject and Assigned(LItemValue.AsObject()) then
              LItemValue.AsObject.Free;
          end;
          DynArraySetLength(PPointer(Result.GetReferenceToRawData)^, Result.TypeInfo, 1, @LArrayLength);
        end;
      end
      else
        DynArraySetLength(PPointer(Result.GetReferenceToRawData)^, Result.TypeInfo, 1, @LArrayLength);
  end;

  LItemParam.NeonObject := TNeonRttiObject.Create(LItemParam.RttiType, FOperation);
  try
    LItemParam.NeonObject.ParseAttributes;

    for LIndex := 0 to Min(LJSONArray.Count,AData.GetArrayLength) - 1 do
    begin
      LItemValue := Result.GetArrayElement(LIndex);
      LItemParam.JSONValue := LJSONArray.Items[LIndex];
      LItemValue := ReadDataMember(LItemParam, LItemValue, True);
      Result.SetArrayElement(LIndex, LItemValue);
    end;

  finally
    LItemParam.NeonObject.Free;
  end;
end;

Hope you like it.

with best regards.

Sorry for my english

Who finds spelling mistakes may keep them.