Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAN-1889] Matrix of Python versions #9

Conversation

juanmanuel-tirado
Copy link
Member

@juanmanuel-tirado juanmanuel-tirado commented May 14, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Prepare an execution matrix to test different python versions.

Related Tickets & Documents

QA Instructions

Check the run has really installed the corresponding Python version. Check the used/installed python versions are correctly set. See https://github.com/pantos-io/common/actions/runs/9078139506

For example:

47s
Run make coverage
  make coverage
  poetry run coverage xml -o coverage-3.[1](https://github.com/pantos-io/common/actions/runs/9078139506/job/24948202095#step:7:1)1.xml
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.11.9/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.9/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    Python[2](https://github.com/pantos-io/common/actions/runs/9078139506/job/24948202095#step:7:2)_ROOT_DIR: /opt/hostedtoolcache/Python/[3](https://github.com/pantos-io/common/actions/runs/9078139506/job/24948202095#step:7:3).11.9/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x6[4](https://github.com/pantos-io/common/actions/runs/9078139506/job/24948202095#step:7:4)
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.9/x64/lib
    VENV: .venv/bin/activate
    PYTHON_VERSION: 3.11
poetry run python3 -m pytest --cov-report term-missing --cov=pantos tests
============================= test session starts ==============================
platform linux -- Python 3.11.9, pytest-7.4.0, pluggy-1.[5](https://github.com/pantos-io/common/actions/runs/9078139506/job/24948202095#step:7:5).0
rootdir: /home/runner/work/common/common
plugins: web3-[6](https://github.com/pantos-io/common/actions/runs/9078139506/job/24948202095#step:7:6).5.0, cov-4.1.0
collected 4997 items

[optional] Are there any post deployment tasks we need to perform?

This PR to work as expected needs a v1 release after this is merged.

@juanmanuel-tirado juanmanuel-tirado marked this pull request as ready for review May 14, 2024 12:32
@juanmanuel-tirado juanmanuel-tirado requested review from a team as code owners May 14, 2024 12:32
Copy link
Contributor

@jpantos jpantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple comments 🚀

.github/actions/install-poetry/action.yml Outdated Show resolved Hide resolved
.github/workflows/sonar.yml Show resolved Hide resolved
@juanmanuel-tirado
Copy link
Member Author

Changes to use inputs for the composite actions. Take a look at https://github.com/pantos-io/common/actions/runs/9109408180 to see the final output.

@juanmanuel-tirado juanmanuel-tirado merged commit 99cb7ff into pantos-io:main May 16, 2024
@juanmanuel-tirado juanmanuel-tirado deleted the PAN-1889-python-version-matrix branch May 16, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants