New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using Safecast whenever do integer casting #54

Open

chefburger opened this issue Jul 3, 2024 · 0 comments

Collaborator

chefburger commented Jul 3, 2024

Per internal review:

One thing i notice is a bunch of casts to uin128 from larger data types, like uint256
E.g.

https://github.com/pancakeswap/pancake-v4-periphery/blob/bd5b3691e8cd19ff01115eae8b985a07fb5715c2/src/pool-cl/NonfungiblePositionManager.sol#L454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment