Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests failing when running yarn verify #6926

Open
evansjohnson opened this issue Jul 25, 2024 · 3 comments · Fixed by #6934
Open

Some tests failing when running yarn verify #6926

evansjohnson opened this issue Jul 25, 2024 · 3 comments · Fixed by #6934

Comments

@evansjohnson
Copy link
Contributor

Environment

  • Package version(s): latest
  • Operating System: macOS Sonoma 14.5
  • Browser name and version: n/a

Steps to reproduce

Follow README.md setup steps up until yarn verify

Actual behavior

The following errors:
Screenshot 2024-07-25 at 1 41 40 PM
Screenshot 2024-07-25 at 1 41 24 PM

Expected behavior

the tests should not error locally but seemingly pass running in CI (TODO: confirm these tests actually are running in CI)

Possible solution

Wondering if all scroll related tests are related to running this on a macbook where the default is to hide scrollbars unless scrolling. I did try changing this operating system setting but saw the same failures (though perhaps a restart would be needed for the changes to take effect here, or I hit some test cache)

@evansjohnson
Copy link
Contributor Author

If https://github.com/palantir/blueprint/pull/6925/files merges make sure readme is re-updated if this is addressed

@ggdouglas
Copy link
Contributor

ggdouglas commented Aug 5, 2024

@evansjohnson I also encountered the error in cssVariables.test.ts (but not the scrollbar issues unfortunately). Decided to dig in a bit and was able to get the test to pass with #6934. This doesn't necessarily address the underlying issue, but it does make the devx a bit better for newcomers (like myself)

@ggdouglas
Copy link
Contributor

Reopening since #6934 doesn't address the whole issue (scroll test flake)

@ggdouglas ggdouglas reopened this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants