Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy PR to Firebase job failing on forks #445

Open
ForestEckhardt opened this issue Mar 18, 2022 · 2 comments
Open

Deploy PR to Firebase job failing on forks #445

ForestEckhardt opened this issue Mar 18, 2022 · 2 comments

Comments

@ForestEckhardt
Copy link
Contributor

There is an issue with the deploy-dev-pr action that is based around the fact that secrets are no longer available to PRs that originate from a fork. This is after a change that github made to increase security. There is however a work around https://github.blog/changelog/2021-02-19-github-actions-workflows-triggered-by-dependabot-prs-will-run-with-read-only-permissions/. In this article a work around it laid out and there is a link to an article around why you may not want to use the workaround. How do we feel about this? Do we want to use the workaround for dependabot and all other forks or just dependabot or neither?

@robdimsdale
Copy link
Member

@ForestEckhardt did this get resolved? I think I've seen recent deployments of my PRs succeed, but I don't know if this would be true for a community contributor who isn't in the contributors/maintainers list.

@ForestEckhardt
Copy link
Contributor Author

I still see it with dependabot update and community members

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants