Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.21, drop 1.19, update default to 1.20 #595

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Add Go 1.21, drop 1.19, update default to 1.20 #595

merged 2 commits into from
Aug 15, 2023

Conversation

motoki317
Copy link
Contributor

Summary

I wanted support for Go 1.21, so I looked up recent change patterns and did the following:

  • Added support for Go 1.21
  • Dropped support for Go 1.19 which will no longer be updated
  • Updated default Go version from 1.19 to 1.20

Use Cases

This will enable Go buildpack users to build with Go 1.21.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@motoki317 motoki317 requested a review from a team as a code owner August 15, 2023 08:20
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 15, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@ForestEckhardt ForestEckhardt added the semver:minor A change requiring a minor version bump label Aug 15, 2023
@ForestEckhardt
Copy link
Contributor

This looks great! Thank you.

@robdimsdale robdimsdale merged commit c7ddb87 into paketo-buildpacks:main Aug 15, 2023
@motoki317 motoki317 deleted the go-1-21 branch August 15, 2023 21:13
@motoki317
Copy link
Contributor Author

Thank you for merging.
@ForestEckhardt Is it a coincidence that the release workflow is failing?
#423

@robdimsdale
Copy link
Member

robdimsdale commented Aug 17, 2023

I'm not sure why the tests are failing. I re-triggered it in CI, and I a ran locally also.

Everything passed locally, but failed again in CI. It seems to be a non-deterministic timeout issue which would indicate some sort of environmental issue 🤔


Update: it passed on another re-run: https://github.com/paketo-buildpacks/go-dist/actions/runs/5868840655/job/15963496429

Even if the issue is related to go 1.21 I don't think it's worth reverting this change. We would have made this change ourselves anyway as we intend on supporting the versions of go that are supported upstream by google.

I do think it's worth us digging into why it seems more flakey on github runners vs locally.

@ForestEckhardt
Copy link
Contributor

I feel like this is a broader issue that I have seen and I would love to see someone try and tackle this issue paketo-buildpacks/packit#473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants