Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not handle suffixes like "Jr." or "Sr." #4

Open
synth opened this issue Oct 1, 2013 · 1 comment
Open

Does not handle suffixes like "Jr." or "Sr." #4

synth opened this issue Oct 1, 2013 · 1 comment

Comments

@synth
Copy link

synth commented Oct 1, 2013

John Henry Johnson Jr. or John Henry Johnson Sr. are currently split as follows:

first_name: John Henry Johnson
last_name: Jr.

not sure if it should it be excise the suffix or append to first_name?
first_name: John Henry Jr.
last_name: Johnson

@pahanix
Copy link
Owner

pahanix commented Oct 2, 2013

Thank you for this example! Need time to figure out.
For now I tend to think to append it to first name like you mentioned above.

Quick search gave me a link to wiki http://en.wikipedia.org/wiki/Suffix_(name)#Generational_titles
There are also II, III, IV etc suffixes.

Also I don't know what to do with names like Henry VIII, Louis XVI, and John Paul II :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants