Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the bundled CA Certificates up to date! #86

Open
BjarniRunar opened this issue May 31, 2020 · 1 comment
Open

Keep the bundled CA Certificates up to date! #86

BjarniRunar opened this issue May 31, 2020 · 1 comment
Assignees

Comments

@BjarniRunar
Copy link
Collaborator

BjarniRunar commented May 31, 2020

We just suffered one of our largest outages ever, because pagekite.py bundles CA Root Certificates instead of relying on those provided by the operating system, and a cert we relied upon expired.

Details here: https://pagekite.wordpress.com/2020/05/30/tls-certificate-validation-issues/

This issue will probably never be closed, unless I automate my build systems so they always pull in up-to-date certs. Otherwise this is a standing reminder to myself to not let this happen again.

(Note, this will be resolved differently on Debian, and we may adopt their solution for our own packages. However, this will remain an issue for the single-file pagekite.py.)

@BjarniRunar BjarniRunar self-assigned this May 31, 2020
@BjarniRunar
Copy link
Collaborator Author

Also: As long as we are embedding CA root certs, we should maybe also teach PageKite to stop trying to validate things once those have expired. Yes, an un-updated, 10-year-old pagekite.py may be quite problematic. But that's likely to only happen in an embedded solution and auto-bricking people's devices is very impolite.

This needs more thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant