Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework wide verification beforeEach / afterEach hooks #80

Open
canny bot opened this issue Jun 26, 2024 · 2 comments
Open

Framework wide verification beforeEach / afterEach hooks #80

canny bot opened this issue Jun 26, 2024 · 2 comments

Comments

@canny
Copy link

canny bot commented Jun 26, 2024

Pact-JS has beforeEach / afterEach state shooks, but they're a bit of a hack. One problem with this hack is that the afterEach hook is called before the state teardown hooks (which is a bit unintuitive).

It would be neat if the pact core had some reserved state names that it always called before / after each test, meaning that the order could be more easily reasoned about. This would give the beforeEach / afterEach functionality to all pact libraries, too.

https://pact.canny.io/admin/board/feature-requests/p/framework-wide-verification-beforeeach-aftereach-hooks

Copy link
Author

canny bot commented Jun 26, 2024

This issue has been linked to a Canny post: Framework wide verification beforeEach / afterEach hooks 🎉

@YOU54F
Copy link
Member

YOU54F commented Jun 26, 2024

Matt Fellows - February 24, 2023

Good call. This would make it easier to explain the lifecycle across the client libraries in a consistent and stable way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant