Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dialog component #276

Open
fuma-nama opened this issue Jun 24, 2024 · 0 comments
Open

Remove Dialog component #276

fuma-nama opened this issue Jun 24, 2024 · 0 comments

Comments

@fuma-nama
Copy link

The dialog of cmdk is a tiny wrapper of Radix UI Dialog, it helps us to implement a search dialog without installing another package manually.

However, it caused some problems:

  • Inconsistent Radix UI dialog versions: when the project uses another version of Radix UI dialog, both of them are used and included into the client bundle.
    It increases the bundle size.
  • Can't Opt-in: People who prefer another component (e.g. popover) or UI library will still be forced to load Radix UI dialog into their client bundle. This is different from other components of cmdk, as the dialog is not necessarily needed.

I would prefer an example in the guide instead of adding it as a part of the library, like how it's previously made. I understand this is a breaking change, but I hope it can be done differently and solves the problem above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant