Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git repos at git.launchpad.net don't work in upstream_project_url #2670

Open
nforro opened this issue Dec 4, 2024 · 2 comments
Open

Git repos at git.launchpad.net don't work in upstream_project_url #2670

nforro opened this issue Dec 4, 2024 · 2 comments
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue.

Comments

@nforro
Copy link
Member

nforro commented Dec 4, 2024

We were not able to parse repo name or repo namespace from the upstream_project_url 'https://git.launchpad.net/dkimpy' defined in the config.

@nforro nforro added the kind/bug Something isn't working. label Dec 4, 2024
@mfocko mfocko self-assigned this Dec 4, 2024
@mfocko mfocko transferred this issue from packit/packit Dec 4, 2024
@mfocko
Copy link
Member

mfocko commented Dec 4, 2024

BTW I also got this, when I tried to open that page:

503 Service Unavailable
No server is available to handle this request.

@mfocko
Copy link
Member

mfocko commented Dec 4, 2024

oh god, this is not coming from ogr, it's a separate logic in the p-s /o\

if self.package_config.upstream_project_url and not (
self.data.event_dict.get("repo_name") and self.data.event_dict.get("repo_namespace")
):
msg_to_report = (
"We were not able to parse repo name or repo namespace from the "
f"upstream_project_url '{self.package_config.upstream_project_url}' "
f"defined in the config."
)
valid = False

@mfocko mfocko transferred this issue from packit/ogr Dec 4, 2024
@mfocko mfocko moved this from in-progress to new in Packit Kanban Board Dec 4, 2024
@mfocko mfocko removed their assignment Dec 4, 2024
@mfocko mfocko added area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue. impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. labels Dec 5, 2024
@mfocko mfocko moved this from new to backlog in Packit Kanban Board Dec 5, 2024
mfocko added a commit to mfocko/ogr that referenced this issue Dec 11, 2024
During the investigation of another issue it appeared that it could be
caused by parsing in the ogr, but adding the test here didn't reveal
anything. Adding the test, just in case, as a part of the regression test
 suite, in case the issue could reappear here sometimes in the future.

Related to packit/packit-service#2670

Signed-off-by: Matej Focko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue.
Projects
Status: backlog
Development

No branches or pull requests

2 participants