Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] can we trigger koji-build (or other packit-service ) ? #2651

Closed
2 tasks
sergiomb2 opened this issue Nov 22, 2024 · 10 comments
Closed
2 tasks

[RFE] can we trigger koji-build (or other packit-service ) ? #2651

sergiomb2 opened this issue Nov 22, 2024 · 10 comments
Assignees
Labels
kind/feature New feature or a request for enhancement.

Comments

@sergiomb2
Copy link

Description

hello, last paragraph of https://packit.dev/docs/fedora-releases-guide/non-divergent-dist-git-branches says "You can work around this bug by manually retriggering the Koji build by commenting on the downstream merged pull request with /packit koji-build " .

packit build in-koji doesn't do the bodhi update and packit create-update --dist-git-branch doesn't do the same of packit-service, for example doesn't close the bugs on bugzilla.

Best regards,

Benefit

more uniform automation

Importance

No response

What is the impacted category (job)?

Fedora release automation

Workaround

  • There is an existing workaround that can be used until this feature is implemented.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@sergiomb2 sergiomb2 added the kind/feature New feature or a request for enhancement. label Nov 22, 2024
@lachmanfrantisek
Copy link
Member

Hi @sergiomb2 ,

I hope you know this already, but Packit CLI is not a client for the Packit Service but a way to run this with your identity locally. (It's on the same level as service.)
Do you think we should make this somewhere more explicit?

Regarding the commands:

So, can these options help in your use case?

  • If yes, we can mention it in the documentation part you've mentioned.
  • If not, can you please suggest what would help you?

@lachmanfrantisek lachmanfrantisek self-assigned this Nov 25, 2024
@sergiomb2 sergiomb2 changed the title [RFE] can we trigger koji-build (or other packit-service ) with packit comand line ? [RFE] can we trigger koji-build (or other packit-service ) ? Nov 25, 2024
@sergiomb2
Copy link
Author

"
Fast Forwarding multiple commits does not automatically trigger a Koji build (Yet)

Unfortunately, there is a bug that prevents Packit from triggering the Koji build when more than one commit has been forwarded in a branch.

You can work around this bug by manually retriggering the Koji build by commenting on the downstream merged pull request with /packit koji-build.
"

Maybe "with packit command line" is confusing because is one suggestion to solve the RFE.

in resume when packit-service fail to run , I'd like have a way to trigger it again .

@lachmanfrantisek
Copy link
Member

@sergiomb2 , if I understand you properly, you want to mention also a way how to overcome this problem via CLI?

We can easily add that. I am just not sure if this isn't too complicated and confusing compared to commenting on a pull-request.

  • You need to install packit package locally and set up authentication.
  • Once you run a job from CLI, the next steps won't be run by Packit Service (by default):
    • This is to not collide with manual interventions (e.g. from other packagers or even proven packagers).
    • You need to update the config with the two options I've mentioned above to let Packit now that it should run also for actions triggered by you.
  • The locally-run jobs are not visible in the dashboard which might be confusing.

So, I can see two options:

  1. Don't promote CLI in this case because it's much easier to comment on a dist-git pull request.
  2. Mention a way to trigger jobs via CLI, but mention all the steps needed to make it work.

Witch one do you prefer? I slightly prefer the first one because it's easier and does not have any downsides.

@lachmanfrantisek
Copy link
Member

From the today's team discussion:

  • We would like to create a new FAQ to describe using Packit CLI together with Packit service and we can link it from places like this.

@majamassarini
Copy link
Member

From the today's team discussion:

  • We would like to create a new FAQ to describe using Packit CLI together with Packit service and we can link it from places like this.

Also related with #1657

@sergiomb2
Copy link
Author

The locally-run jobs are not visible in the dashboard which might be confusing.

is more than confusing, doesn't do the same , the owners of builds are different, the user which create update is me and is not packit , I have do it in two steps [1] at least and "packit create-update" doesn't close bugs as packit service do .

On other hand one pull requests just to request packit service , is not a good option for me , history on git and of PRs will not be elegant

[1]
packit build in-koji --dist-git-branch f40
packit create-update --dist-git-branch f40

@sergiomb2
Copy link
Author

Also related with #1657

"We should give maintainers the ability to overcome a failing automation."

yes, definitively is what I'm asking in this issue , overcome a failing automation without hacking and with the same automation if it isn't much difficult.

we have packit build and packit create-update but isn't the same in my point of view , maybe was meant to be , I don't know

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Dec 2, 2024

is more than confusing, doesn't do the same , the owners of builds are different, the user which create update is me and is not packit , I have do it in two steps [1] at least and "packit create-update" doesn't close bugs as packit service do .

That's exactly what I meant. Unless we have a real client CLI, we can't fix these issues.

On other hand one pull requests just to request packit service , is not a good option for me , history on git and of PRs will not be elegant

Not sure if I fully follow, but you can use any dist-git PR to retrigger the job. And I don't think information about retriggering needs to be saved in git. It's like a "rerun" button.

But to have something actionable:

I hope this works for you

@sergiomb2
Copy link
Author

Not sure if I fully follow, but you can use any dist-git PR to retrigger the job. And I don't think information about retriggering needs to be saved in git. It's like a "rerun" button.

I see, we can use an old PR to retigger the job ? can I use one close PR ? well, this ticket is just about retigger the job without use an (new) PR.
OK, and if I want retrigger for an branch, let says f41 for example, do I need have a PR asking to merge f41 branch ?

Thank you,

Reading week 44, https://packit.dev/posts/weekly/2024/week-44#week-44-october-29th--november-4th I'll add this [1] to almost all configuration , and I will see how it goes ...

rawhide:
      fast_forward_merge_into: [fedora-branched]

@sergiomb2
Copy link
Author

fast_forward_merge_into: [fedora-branched] worked well, now I got PR(s) for all branches , if something fail, I can use the PR in question to re-trigger any event . So everything is solved
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or a request for enhancement.
Projects
Status: done
Development

No branches or pull requests

3 participants