-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.git repo not present in the BUILD/ dir after running %prep #92
Comments
the problem here is these packages change directories (#58) and the build will never pass with the current d2s & packit we can tinker d2s so that source-git repos will get created though (but build won't pass b/c packit won't be able to recreate patches correctly) let's look at openblas:
the way we hijack rpm macros right now is that we override %patch and %autosetup, so with the first %patch invocation, the git repo is created (in %patch0) but as you can see, we changed directory which is confusing d2s and this is also the problem for recreating patches: packit creates them from the root of the source-git repo while they are being applied here in a subdirectory - we'd need to store that information that leading dirs should be stripped |
Sometimes packages have multiple sources (= archives) which they unpack during %prep in different ways. This can be done with `%setup -aN -aM`. Sadly `%autosetup -aN -aM` does not work: https://bugzilla.redhat.com/show_bug.cgi?id=1881840 So we need to turn back into overwriting %setup unless we detect this use case. But the eternal problem with patches applied in a subdir persists. Fixes some of packit#92 Signed-off-by: Tomas Tomecek <[email protected]>
Sometimes packages have multiple sources (= archives) which they unpack during %prep in different ways. This can be done with `%setup -aN -aM`. Sadly `%autosetup -aN -aM` does not work: https://bugzilla.redhat.com/show_bug.cgi?id=1881840 So we need to turn back into overwriting %setup unless we detect this use case. But the eternal problem with patches applied in a subdir persists. Fixes some of packit#92 Signed-off-by: Tomas Tomecek <[email protected]>
Sometimes packages have multiple sources (= archives) which they unpack during %prep in different ways. This can be done with `%setup -aN -aM`. Sadly `%autosetup -aN -aM` does not work: https://bugzilla.redhat.com/show_bug.cgi?id=1881840 So we need to turn back into overwriting %setup unless we detect this use case. But the eternal problem with patches applied in a subdir persists. Fixes some of packit#92 Signed-off-by: Tomas Tomecek <[email protected]>
Sometimes packages have multiple sources (= archives) which they unpack during %prep in different ways. This can be done with `%setup -aN -aM`. Sadly `%autosetup -aN -aM` does not work: https://bugzilla.redhat.com/show_bug.cgi?id=1881840 So we need to turn back into overwriting %setup unless we detect this use case. But the eternal problem with patches applied in a subdir persists. Fixes some of packit#92 Signed-off-by: Tomas Tomecek <[email protected]>
This occurred again, seen on packages (c8):
The text was updated successfully, but these errors were encountered: