Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert create_project_ssh_key error work-arounds #105

Open
displague opened this issue Jan 27, 2021 · 0 comments
Open

Revert create_project_ssh_key error work-arounds #105

displague opened this issue Jan 27, 2021 · 0 comments

Comments

@displague
Copy link
Member

displague commented Jan 27, 2021

It should now be safe to remove the workaround to #78:

except ResponseError as e:
if e.response.status_code == 422:
# Try to pluck the SSH key from the listing API
keys = [
key
for key in self.list_ssh_keys()
if key.key.strip() == public_key.strip()
]
if len(keys) == 1:
return keys.pop()
raise

The function should be returned to its original composition from #80.

Other changes from #80 can be retained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant