-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Mastodon Redirect support and "Open Link" share target #365
base: main
Are you sure you want to change the base?
Conversation
36bf80d
to
5aaa29b
Compare
Hi, thanks for the PR. I've been a bit sidetracked this week bug fixing ahead of the 2.2 release, but I'll look at this properly next week. |
5aaa29b
to
65e7803
Compare
65e7803
to
329e3da
Compare
app/src/main/java/app/pachli/components/view/ViewLinkActivity.kt
Outdated
Show resolved
Hide resolved
Hi, First, sorry for the delay in getting to reviewing this, I've been a bit wrapped up in cleaning up the bugs exposed by the migration to Moshi. I've merged I've got a couple of specific questions about the approach.
And a more general architecture point: The UX for this as a user seems quite hostile; download an app from GitHub, download additional apps, one of which (LinkSheet) has a non-standard license. So what if, instead of the current approach:
If I've understood LinkSheet properly this might be quite similar to what LinkSheet is already doing. |
I don't think Google would accept the apps, and if they did, they'd only accept one variant since they're probably "too similar". The number of URLs especially Mastodon Redirect handles can cause Settings to crash when manually selecting URLs, which would probably lead to a rejection if the list alone didn't. I think the apps should be F-DROID eligible, but I haven't looked into it too much. Right now, they're also available on IzzyOnDroid's F-DROID repo, so checking GitHub for new releases isn't necessary. I don't have a set frequency for updates, but the variants are probably due for a domain refresh. The idea isn't necessarily to be super up-to-date on new single-user and small instances, just to be able to handle as many as possible and take that load off of individual clients. In order to handle all links, Mastodon Redirect would need to be set as the default browser. On top of making it even less likely to be accepted by the Play Store, it'd add a lot of complexity to duplicate the URL validation that most clients already have, along with the complexity from duplicating LinkSheet's main function. The upside is that most people will only need to do the setup after the initial install, since domains that are added in updates are mostly small or single-user that won't be having many (or any) links shared from them. Mastodon Redirect's (and the variants') purpose is to hook into existing apps for the most part as simply as possible to add deep linking support to them without them having to add their own lists of domains. Moving to only |
Very similar to tuskyapp/Tusky#4194. Modified description below.
This PR adds auto-detect support for Mastodon Redirect, so Pachli can be chosen for opening Mastodon links. It also adds an "Open Link" share target which uses the same logic path Mastodon Redirect does.
To test:
To test the share target: