Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix varint decoding #20

Closed
wants to merge 1 commit into from
Closed

Fix varint decoding #20

wants to merge 1 commit into from

Conversation

achaulk
Copy link

@achaulk achaulk commented Apr 10, 2023

Fixes #16
Not enough bytes were being consumed in decoding
Also INT_MIN was decoding as 0

@f-michaut
Copy link
Contributor

Hi @achaulk, it looks like the tests are failing for Ubuntu, could you fix it?

I would like to use alpaca with std::size_t types which would suffer from this issue if their value is UINT64_MAX.

@achaulk
Copy link
Author

achaulk commented Dec 13, 2023

I don't use this anymore, wrote my own

@achaulk achaulk closed this Dec 13, 2023
@achaulk achaulk deleted the varint branch December 13, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integer value problem
2 participants
@achaulk @f-michaut