-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global CSS names missing namespaces #36
Comments
Hello @solomon23, can you review this PR #50 ? Did I understand you correctly? Every |
@DiggesT I don't think that's what was meant. Many of the CSS classnames used in this library can end up conflicting with existing styles. A common solution to this would be to prefix the classnames (for example with This would allow us to easily override the styles of Verbum components without side effects. |
Ya what @squishyu said |
In case anyone wants to push this forward, I have forked this repo with some personalized changes - the first one being adding className prefixes: squishyu@c578c74 It would need some cleaning up and frankly, I don't have enough free time for that. |
The css in this project isn't namespaced which means it's pretty much unusable to insert anywhere
verbum/src/EditorComposer.css
Line 308 in fccf4b1
One good example is
dropdown
which is a pretty generic style name to globally overwriteThe text was updated successfully, but these errors were encountered: