Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global CSS names missing namespaces #36

Open
solomon23 opened this issue Mar 23, 2023 · 4 comments
Open

global CSS names missing namespaces #36

solomon23 opened this issue Mar 23, 2023 · 4 comments

Comments

@solomon23
Copy link

The css in this project isn't namespaced which means it's pretty much unusable to insert anywhere

.icon.dropdown-more {

One good example is dropdown which is a pretty generic style name to globally overwrite

@DiggesT
Copy link
Collaborator

DiggesT commented May 25, 2023

Hello @solomon23, can you review this PR #50 ?

Did I understand you correctly? Every .css file should have his own namespace, and components that used it should be wrapped into <svg> tag which define namespace?

@squishyu
Copy link

squishyu commented Nov 6, 2023

@DiggesT I don't think that's what was meant. Many of the CSS classnames used in this library can end up conflicting with existing styles.

A common solution to this would be to prefix the classnames (for example with verbum-) - so instead of dropdown it would be verbum-dropdown.

This would allow us to easily override the styles of Verbum components without side effects.

@solomon23
Copy link
Author

Ya what @squishyu said

@squishyu
Copy link

squishyu commented Nov 25, 2023

In case anyone wants to push this forward, I have forked this repo with some personalized changes - the first one being adding className prefixes: squishyu@c578c74

It would need some cleaning up and frankly, I don't have enough free time for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants