-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deathrattle #5
Comments
There is a trigger for it... kinda. Every minion death should trigger a call to Minion.destroyed(), so the plan is to have death rattle minions override destroyed() to do its effects. It is untested though, and the destroyed() trigger order is certainly wrong. My idea to fix the ordering issue is to wrap the p0_minions_ and p1_minions_ list within a custom list class that returns an iterator in the right order (FIFO). Definitely open to suggestions though. |
Added an example Deathrattle implementation, Loot Hoarder. |
Awesome, I'll work on some minions with death rattle. Thanks for the quick update. |
This can probably be closed now since we've continued to add Deathrattle support. |
There is a way already to do battle cries, but I've been looking and I can't seem to find any code to handle death rattles. Is this correct or am I just missing it?
The text was updated successfully, but these errors were encountered: