Added linting/vetting to GitHub CI (#14)

* Added linting/vetting to GitHub CI * Fixed some vet errors
oxisto · Feb 25, 2022 · 4347b01 · 4347b01
1 parent a531c27
commit 4347b01
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -17,8 +17,11 @@ jobs:
         with:
           go-version: 1.17
 
+      - name: Lint
+        run: go vet ./...
+
       - name: Build
-        run: go build -v ./...
+        run: go build ./...
 
       - name: Test
         run: go test -v -coverprofile=coverage.cov -coverpkg ./... -covermode=atomic ./...

diff --git a/cmd/server/server_test.go b/cmd/server/server_test.go
@@ -9,10 +9,16 @@ import (
 )
 
 func Test_main(t *testing.T) {
-	var wg sync.WaitGroup
+	var (
+		wg  sync.WaitGroup
+		err error
+	)
 	wg.Add(1)
 
-	flag.Set("port", "0")
+	err = flag.Set("port", "0")
+	if err != nil {
+		t.Errorf("Error while setting flag: %v", err)
+	}
 
 	ctx = func(net.Listener) context.Context {
 		wg.Done()

diff --git a/server_test.go b/server_test.go
@@ -17,7 +17,6 @@ import (
 
 func TestAuthorizationServer_handleToken(t *testing.T) {
 	type fields struct {
-		Server     http.Server
 		clients    []*Client
 		signingKey *ecdsa.PrivateKey
 	}
@@ -53,7 +52,6 @@ func TestAuthorizationServer_handleToken(t *testing.T) {
 			rr := httptest.NewRecorder()
 
 			srv := &AuthorizationServer{
-				Server:     tt.fields.Server,
 				clients:    tt.fields.clients,
 				signingKey: tt.fields.signingKey,
 			}
@@ -69,7 +67,6 @@ func TestAuthorizationServer_handleToken(t *testing.T) {
 
 func TestAuthorizationServer_retrieveClient(t *testing.T) {
 	type fields struct {
-		Server     http.Server
 		clients    []*Client
 		signingKey *ecdsa.PrivateKey
 	}
@@ -149,7 +146,6 @@ func TestAuthorizationServer_retrieveClient(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			srv := &AuthorizationServer{
-				Server:     tt.fields.Server,
 				clients:    tt.fields.clients,
 				signingKey: tt.fields.signingKey,
 			}
@@ -167,7 +163,6 @@ func TestAuthorizationServer_retrieveClient(t *testing.T) {
 
 func TestAuthorizationServer_handleJWKS(t *testing.T) {
 	type fields struct {
-		Server     http.Server
 		clients    []*Client
 		signingKey *ecdsa.PrivateKey
 	}
@@ -219,7 +214,6 @@ func TestAuthorizationServer_handleJWKS(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			srv := &AuthorizationServer{
-				Server:     tt.fields.Server,
 				clients:    tt.fields.clients,
 				signingKey: tt.fields.signingKey,
 			}
@@ -291,7 +285,6 @@ func Test_writeJSON(t *testing.T) {
 
 func TestAuthorizationServer_doClientCredentialsFlow(t *testing.T) {
 	type fields struct {
-		Server     http.Server
 		clients    []*Client
 		signingKey *ecdsa.PrivateKey
 	}
@@ -363,7 +356,6 @@ func TestAuthorizationServer_doClientCredentialsFlow(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			srv := &AuthorizationServer{
-				Server:     tt.fields.Server,
 				clients:    tt.fields.clients,
 				signingKey: tt.fields.signingKey,
 			}