diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 1bd68fc..c8f4ce7 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -11,19 +11,16 @@ on:
jobs:
build:
-
runs-on: ubuntu-latest
-
steps:
- - uses: actions/checkout@v3
- - name: Set up JDK 1.8
- uses: actions/setup-java@v3
+ - uses: actions/checkout@v4
+ - uses: actions/setup-java@v4
with:
- java-version: 8
+ java-version-file: .java-version
distribution: temurin
cache: maven
- name: Build with Maven
- run: mvn -B package --file pom.xml
+ run: mvn -B package
# This is part of the release task so we don't want to allow failures.
- name: Build JavaDoc with Maven
- run: mvn -B javadoc:javadoc --file pom.xml
+ run: mvn -B javadoc:javadoc
diff --git a/.java-version b/.java-version
new file mode 100644
index 0000000..8e2afd3
--- /dev/null
+++ b/.java-version
@@ -0,0 +1 @@
+17
\ No newline at end of file
diff --git a/pom.xml b/pom.xml
index f281175..b4d0063 100644
--- a/pom.xml
+++ b/pom.xml
@@ -4,7 +4,7 @@
uk.ac.ox.ctl
canvas-spring-oauth2
- 0.7-SNAPSHOT
+ 1.0-SNAPSHOT
Spring Security OAuth2 for Canvas
This small project provides some supporting classes for using Spring Security OAuth2 with Canvas.
https://github.com/oxctl/canvas-spring-oauth2
@@ -44,8 +44,8 @@
- 1.8
- 1.8
+ 17
+ 17
UTF-8
@@ -53,20 +53,19 @@
org.springframework.security
spring-security-oauth2-client
- 5.8.2
+ 6.3.0
org.springframework
spring-web
- 5.3.25
+ 6.1.9
-
- javax.servlet
- javax.servlet-api
- 3.0.1
- provided
+ jakarta.platform
+ jakarta.jakartaee-api
+ 10.0.0
+
com.google.code.findbugs
annotations
@@ -74,6 +73,13 @@
compile
+
+
+ maven_central
+ Maven Central
+ https://repo.maven.apache.org/maven2/
+
+
diff --git a/src/main/java/uk/ac/ox/ctl/oauth2/client/endpoint/CanvasOAuth2AuthorizationCodeGrantRequestEntityConverter.java b/src/main/java/uk/ac/ox/ctl/oauth2/client/endpoint/CanvasOAuth2AuthorizationCodeGrantRequestEntityConverter.java
index d21dd93..1cf71b8 100644
--- a/src/main/java/uk/ac/ox/ctl/oauth2/client/endpoint/CanvasOAuth2AuthorizationCodeGrantRequestEntityConverter.java
+++ b/src/main/java/uk/ac/ox/ctl/oauth2/client/endpoint/CanvasOAuth2AuthorizationCodeGrantRequestEntityConverter.java
@@ -87,8 +87,7 @@ private MultiValueMap buildFormParameters(
authorizationExchange.getAuthorizationRequest().getRedirectUri());
// This is the special Canvas bit.
formParameters.add(REPLACE_TOKENS, REPLACE_TOKENS_VALUE);
- if (ClientAuthenticationMethod.CLIENT_SECRET_POST.equals(clientRegistration.getClientAuthenticationMethod()) || ClientAuthenticationMethod.POST.equals(
- clientRegistration.getClientAuthenticationMethod())) {
+ if (ClientAuthenticationMethod.CLIENT_SECRET_POST.equals(clientRegistration.getClientAuthenticationMethod()) ) {
formParameters.add(OAuth2ParameterNames.CLIENT_ID, clientRegistration.getClientId());
formParameters.add(OAuth2ParameterNames.CLIENT_SECRET, clientRegistration.getClientSecret());
} else {
diff --git a/src/main/java/uk/ac/ox/ctl/oauth2/client/endpoint/OAuth2AuthorizationGrantRequestEntityUtils.java b/src/main/java/uk/ac/ox/ctl/oauth2/client/endpoint/OAuth2AuthorizationGrantRequestEntityUtils.java
index 285c1ad..e4006aa 100644
--- a/src/main/java/uk/ac/ox/ctl/oauth2/client/endpoint/OAuth2AuthorizationGrantRequestEntityUtils.java
+++ b/src/main/java/uk/ac/ox/ctl/oauth2/client/endpoint/OAuth2AuthorizationGrantRequestEntityUtils.java
@@ -48,7 +48,7 @@ final class OAuth2AuthorizationGrantRequestEntityUtils {
static HttpHeaders getTokenRequestHeaders(ClientRegistration clientRegistration) {
HttpHeaders headers = new HttpHeaders();
headers.addAll(DEFAULT_TOKEN_REQUEST_HEADERS);
- if (ClientAuthenticationMethod.BASIC.equals(
+ if (ClientAuthenticationMethod.CLIENT_SECRET_BASIC.equals(
clientRegistration.getClientAuthenticationMethod())) {
headers.setBasicAuth(clientRegistration.getClientId(), clientRegistration.getClientSecret());
}
diff --git a/src/main/java/uk/ac/ox/ctl/oauth2/client/web/method/annotation/OAuth2AuthorizedClientArgumentResolver.java b/src/main/java/uk/ac/ox/ctl/oauth2/client/web/method/annotation/OAuth2AuthorizedClientArgumentResolver.java
index ff6464b..14a3776 100644
--- a/src/main/java/uk/ac/ox/ctl/oauth2/client/web/method/annotation/OAuth2AuthorizedClientArgumentResolver.java
+++ b/src/main/java/uk/ac/ox/ctl/oauth2/client/web/method/annotation/OAuth2AuthorizedClientArgumentResolver.java
@@ -15,6 +15,8 @@
*/
package uk.ac.ox.ctl.oauth2.client.web.method.annotation;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
import org.springframework.core.MethodParameter;
import org.springframework.core.annotation.AnnotatedElementUtils;
import org.springframework.lang.Nullable;
@@ -40,8 +42,6 @@
import org.springframework.web.method.support.ModelAndViewContainer;
import uk.ac.ox.ctl.oauth2.client.annotation.RegisteredOAuth2AuthorizedClient;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
/**
* An implementation of a {@link HandlerMethodArgumentResolver} that is capable of resolving a