Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angualr 9? #144

Open
yogeshvn opened this issue Jun 8, 2020 · 5 comments
Open

Support Angualr 9? #144

yogeshvn opened this issue Jun 8, 2020 · 5 comments

Comments

@yogeshvn
Copy link

yogeshvn commented Jun 8, 2020

in angualr 9 giving follwing issue
modules/amazing-time-picker/node_modules/rxjs/Rx'. This is probably not a problem, but may cause the compilation of
entry points to be out of order.

@yogeshvn yogeshvn changed the title Support Angualr? Support Angualr 9? Jun 8, 2020
@markyleong
Copy link

The full warning message is:

Warning: Entry point 'amazing-time-picker' contains deep imports into '/node_modules/amazing-time-picker/node_modules/rxjs/Rx'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

@mwawrusch
Copy link

Actually let's make this support for Angular 10 :)

@ssougnez
Copy link

ssougnez commented Sep 9, 2020

At this rate, it will probably be Angular 12...

@JoniJnm
Copy link

JoniJnm commented Jan 4, 2021

I did a fork to compile the project in angular 11.

There are a lot of files changed, that's why I didn't send a PR (I didn't edit the original files)

https://github.com/JoniJnm/amazing-time-picker

@ivanhdzd
Copy link

I did a fork to compile the project in angular 11.

There are a lot of files changed, that's why I didn't send a PR (I didn't edit the original files)

https://github.com/JoniJnm/amazing-time-picker

Thank you so much @JoniJnm, I confirm that your fork works in Angular 12!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants