-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add four columns option to {.people-rows} #4276
base: master
Are you sure you want to change the base?
Conversation
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-12-10 18:57:28 UTC |
3dcd7c7
to
7c17048
Compare
7c17048
to
193b94b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I didn't test all the new CSS overrides, presumably we can do that in a final pass of the draft pages.
{ | ||
"people-cols-2 grid-md-cols-1": columns === "2", | ||
"grid-cols-2": !columns, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a case we actually want to support? It looks pretty squished on mobile when the columns don't collapse - should columns
default to 2
instead?
@include h1-semibold; | ||
color: $blue-60; | ||
margin-top: 0; | ||
|
||
&:has(+ .article-block__side-by-side) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but I think you could also write this as
+ .article-block__side-by-side {
margin-top: a good value;
}
if you wanted to avoid the :has
selector 🙂
Also fixes some unrelated styling issues.