Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add four columns option to {.people-rows} #4276

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Dec 10, 2024

image

Also fixes some unrelated styling issues.

@rakyi rakyi requested a review from ikesau December 10, 2024 18:38
@owidbot
Copy link
Contributor

owidbot commented Dec 10, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-people-four-cols

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-12-10 18:57:28 UTC
Execution time: 1.20 seconds

Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I didn't test all the new CSS overrides, presumably we can do that in a final pass of the draft pages.

{
"people-cols-2 grid-md-cols-1": columns === "2",
"grid-cols-2": !columns,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a case we actually want to support? It looks pretty squished on mobile when the columns don't collapse - should columns default to 2 instead?

@include h1-semibold;
color: $blue-60;
margin-top: 0;

&:has(+ .article-block__side-by-side) {
Copy link
Member

@ikesau ikesau Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but I think you could also write this as

+ .article-block__side-by-side {
  margin-top: a good value;
}

if you wanted to avoid the :has selector 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants