Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (slope) redesign / TAS-722 #4222

Merged
merged 46 commits into from
Dec 11, 2024
Merged

✨ (slope) redesign / TAS-722 #4222

merged 46 commits into from
Dec 11, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Nov 26, 2024

Summary

  • Entity names are usually only shown only on the right side
  • If it would be otherwise difficult to match a label on the left to the corresponding slope, then the entity name is repeated
    • The heuristic here uses the number of levels used by the line legend, the actual threshold (4) is arbitrary of course
  • We prefer to add labels on the left if they're also labelled on the right (this is only important if labels are dropped due to space constraints)
  • Entity annotations are hidden on smaller screens
  • Entity annotations are also shown in the tooltip (line charts show entity annotations in the tooltip as well)

Future improvements

  • Show hidden line legend labels on hover
  • Toggling the No Data section is quite disruptive. Once we make changes to the entity selector that account for the No data problem, we should remove the section

Testing

The Multiembedder problem is hot-fixed on this staging site for testing.

@sophiamersmann sophiamersmann changed the title (slope) redesign ✨ (slope) redesign Nov 26, 2024
@owidbot
Copy link
Contributor

owidbot commented Nov 26, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-slope-redesign-viz

SVG tester:

Number of differences (default views): 1294 (bf9ca8) ❌
Number of differences (all views): 452 (d355e2) ❌

Edited: 2024-12-11 12:33:01 UTC
Execution time: 1.38 seconds

@sophiamersmann sophiamersmann changed the base branch from migrate-slopes-viz to admin-slope-viz November 27, 2024 15:57
@sophiamersmann sophiamersmann changed the base branch from admin-slope-viz to slope-tolerance-viz November 29, 2024 17:01
@sophiamersmann sophiamersmann force-pushed the slope-redesign-viz branch 4 times, most recently from 5f84cc6 to 1afb4ee Compare December 6, 2024 09:33
@sophiamersmann sophiamersmann marked this pull request as ready for review December 6, 2024 13:26
@sophiamersmann sophiamersmann merged commit e87de50 into master Dec 11, 2024
13 of 15 checks passed
@sophiamersmann sophiamersmann deleted the slope-redesign-viz branch December 11, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants