Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 (slope) add tolerance / TAS-719 #4205

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Nov 22, 2024

Adds tolerance to slope charts.

If the original times of start and end value are too close together, then we don't show the slope. This is something that came out of discussion with Joe and Daniel, but now that I'm working on this, I don't think we need to be that strict? As long as the original start time < the original end time, we should be good? Curious what you think!

Testing

Example charts:

@sophiamersmann sophiamersmann changed the title (slope) add tolerance 🎉 (slope) add tolerance Nov 22, 2024
@owidbot
Copy link
Contributor

owidbot commented Nov 22, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-slope-tolerance-viz

SVG tester:

Number of differences (default views): 26 (12f606) ❌
Number of differences (all views): 22 (cfe3e7) ❌

Edited: 2024-12-11 12:32:04 UTC
Execution time: 1.35 seconds

@sophiamersmann sophiamersmann changed the title 🎉 (slope) add tolerance 🎉 (slope) add tolerance / TAS-719 Nov 22, 2024
Copy link

@sophiamersmann sophiamersmann force-pushed the slope-tolerance-viz branch 2 times, most recently from 4032afa to 85e664c Compare November 25, 2024 11:21
@sophiamersmann sophiamersmann force-pushed the slope-tolerance-viz branch 2 times, most recently from 1a1539d to 89acddc Compare November 26, 2024 09:21
@sophiamersmann sophiamersmann force-pushed the redesign-slopes-viz branch 2 times, most recently from da9c176 to ff1aa25 Compare November 26, 2024 09:57
@sophiamersmann sophiamersmann force-pushed the redesign-slopes-viz branch 2 times, most recently from b83a9d3 to 3100127 Compare December 11, 2024 12:15
Copy link
Member Author

sophiamersmann commented Dec 11, 2024

Merge activity

  • Dec 11, 7:47 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 11, 7:50 AM EST: Graphite rebased this pull request as part of a merge.
  • Dec 11, 7:51 AM EST: A user merged this pull request with Graphite.

@sophiamersmann sophiamersmann changed the base branch from redesign-slopes-viz to graphite-base/4205 December 11, 2024 12:47
@sophiamersmann sophiamersmann changed the base branch from graphite-base/4205 to master December 11, 2024 12:48
@sophiamersmann sophiamersmann merged commit 93cd99a into master Dec 11, 2024
13 of 15 checks passed
@sophiamersmann sophiamersmann deleted the slope-tolerance-viz branch December 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants