-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 (slope) add tolerance / TAS-719 #4205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
10 tasks
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 26 (12f606) ❌ Edited: 2024-12-11 12:32:04 UTC |
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
November 22, 2024 13:08
7debb1b
to
4e688db
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 22, 2024 13:15
196784f
to
96236e6
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
November 22, 2024 13:15
4e688db
to
23e472d
Compare
sophiamersmann
changed the title
🎉 (slope) add tolerance
🎉 (slope) add tolerance / TAS-719
Nov 22, 2024
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 22, 2024 15:02
96236e6
to
f63bed0
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
November 22, 2024 15:02
23e472d
to
283ae7d
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 22, 2024 16:01
f63bed0
to
1b31ea6
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
2 times, most recently
from
November 25, 2024 11:21
4032afa
to
85e664c
Compare
6 tasks
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 25, 2024 17:10
1b31ea6
to
94f3497
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
November 25, 2024 17:10
85e664c
to
3afcaf3
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 26, 2024 09:09
94f3497
to
891c6d1
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
2 times, most recently
from
November 26, 2024 09:21
1a1539d
to
89acddc
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
2 times, most recently
from
November 26, 2024 09:57
da9c176
to
ff1aa25
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
November 26, 2024 09:57
89acddc
to
689b3b5
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
November 26, 2024 17:35
ff1aa25
to
54e35d3
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
November 26, 2024 17:35
689b3b5
to
200c379
Compare
This was referenced Dec 2, 2024
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
December 5, 2024 15:54
195acc1
to
d8192ae
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
December 5, 2024 15:54
da28f26
to
988e436
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
December 9, 2024 15:13
d8192ae
to
0922b23
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
December 9, 2024 15:13
988e436
to
47945ae
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
December 10, 2024 17:14
0922b23
to
7d2a220
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
December 10, 2024 17:14
47945ae
to
5d3abb5
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
December 10, 2024 17:25
5d3abb5
to
0bb2ea0
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
December 11, 2024 10:16
88fa808
to
d87da92
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
December 11, 2024 10:16
0bb2ea0
to
79445b9
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
from
December 11, 2024 11:38
d87da92
to
8fd6a86
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
December 11, 2024 11:38
79445b9
to
74d207c
Compare
sophiamersmann
force-pushed
the
redesign-slopes-viz
branch
2 times, most recently
from
December 11, 2024 12:15
b83a9d3
to
3100127
Compare
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
December 11, 2024 12:15
74d207c
to
716333a
Compare
sophiamersmann
changed the base branch from
redesign-slopes-viz
to
graphite-base/4205
December 11, 2024 12:47
sophiamersmann
force-pushed
the
slope-tolerance-viz
branch
from
December 11, 2024 12:50
716333a
to
a471814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tolerance to slope charts.
If the original times of start and end value are too close together, then we don't show the slope. This is something that came out of discussion with Joe and Daniel, but now that I'm working on this, I don't think we need to be that strict? As long as the original start time < the original end time, we should be good? Curious what you think!
Testing
Example charts: