-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Fix explorer edit button #4105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
danyx23
changed the title
🚧 WIP fixing explorer link issue
🚧 WIP fix explorer edit button
Nov 4, 2024
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-11-04 10:10:45 UTC |
danyx23
force-pushed
the
fix-mdim-edit-hack
branch
from
November 4, 2024 14:25
e98739a
to
9fa24fa
Compare
danyx23
force-pushed
the
fix-explorer-edit-link
branch
2 times, most recently
from
November 4, 2024 16:13
aa912cf
to
e21667b
Compare
danyx23
force-pushed
the
fix-mdim-edit-hack
branch
from
November 4, 2024 17:06
9fa24fa
to
4cf6efb
Compare
danyx23
force-pushed
the
fix-mdim-edit-hack
branch
from
November 4, 2024 17:10
4cf6efb
to
cd7bcf8
Compare
danyx23
force-pushed
the
fix-explorer-edit-link
branch
from
November 4, 2024 17:10
e21667b
to
9e1b440
Compare
danyx23
force-pushed
the
fix-mdim-edit-hack
branch
from
November 4, 2024 17:16
cd7bcf8
to
76b50b2
Compare
danyx23
force-pushed
the
fix-explorer-edit-link
branch
from
November 4, 2024 17:16
9e1b440
to
e1691ed
Compare
marcelgerber
approved these changes
Nov 6, 2024
danyx23
force-pushed
the
fix-mdim-edit-hack
branch
from
November 14, 2024 17:55
76b50b2
to
4575974
Compare
danyx23
force-pushed
the
fix-explorer-edit-link
branch
from
November 14, 2024 17:55
e1691ed
to
6b967e2
Compare
danyx23
changed the base branch from
fix-mdim-edit-hack
to
graphite-base/4105
November 14, 2024 17:59
danyx23
force-pushed
the
fix-explorer-edit-link
branch
from
November 14, 2024 18:00
6b967e2
to
3fdfdbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug reported in #4033 where the edit button in the share menu of grapher does not point to the right location for explorers