Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Fix explorer edit button #4105

Merged
merged 1 commit into from
Nov 14, 2024
Merged

🔨 Fix explorer edit button #4105

merged 1 commit into from
Nov 14, 2024

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Nov 4, 2024

This PR fixes the bug reported in #4033 where the edit button in the share menu of grapher does not point to the right location for explorers

Copy link
Contributor Author

danyx23 commented Nov 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danyx23 and the rest of your teammates on Graphite Graphite

@danyx23 danyx23 linked an issue Nov 4, 2024 that may be closed by this pull request
@danyx23 danyx23 changed the title 🚧 WIP fixing explorer link issue 🚧 WIP fix explorer edit button Nov 4, 2024
@owidbot
Copy link
Contributor

owidbot commented Nov 4, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-fix-explorer-edit-link

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-04 10:10:45 UTC
Execution time: 1.17 seconds

@danyx23 danyx23 force-pushed the fix-mdim-edit-hack branch from e98739a to 9fa24fa Compare November 4, 2024 14:25
@danyx23 danyx23 force-pushed the fix-explorer-edit-link branch 2 times, most recently from aa912cf to e21667b Compare November 4, 2024 16:13
@danyx23 danyx23 changed the title 🚧 WIP fix explorer edit button 🚧 Fix explorer edit button Nov 4, 2024
@danyx23 danyx23 changed the title 🚧 Fix explorer edit button 🔨 Fix explorer edit button Nov 4, 2024
@danyx23 danyx23 force-pushed the fix-mdim-edit-hack branch from 9fa24fa to 4cf6efb Compare November 4, 2024 17:06
@danyx23 danyx23 force-pushed the fix-mdim-edit-hack branch from 4cf6efb to cd7bcf8 Compare November 4, 2024 17:10
@danyx23 danyx23 force-pushed the fix-explorer-edit-link branch from e21667b to 9e1b440 Compare November 4, 2024 17:10
@danyx23 danyx23 force-pushed the fix-mdim-edit-hack branch from cd7bcf8 to 76b50b2 Compare November 4, 2024 17:16
@danyx23 danyx23 force-pushed the fix-explorer-edit-link branch from 9e1b440 to e1691ed Compare November 4, 2024 17:16
@danyx23 danyx23 marked this pull request as ready for review November 4, 2024 17:23
@danyx23 danyx23 requested a review from marcelgerber November 4, 2024 17:24
@danyx23 danyx23 force-pushed the fix-explorer-edit-link branch from e1691ed to 6b967e2 Compare November 14, 2024 17:55
Copy link
Contributor Author

danyx23 commented Nov 14, 2024

Merge activity

  • Nov 14, 12:59 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 14, 1:01 PM EST: Graphite rebased this pull request as part of a merge.
  • Nov 14, 1:04 PM EST: A user merged this pull request with Graphite.

@danyx23 danyx23 changed the base branch from fix-mdim-edit-hack to graphite-base/4105 November 14, 2024 17:59
@danyx23 danyx23 changed the base branch from graphite-base/4105 to master November 14, 2024 17:59
@danyx23 danyx23 force-pushed the fix-explorer-edit-link branch from 6b967e2 to 3fdfdbb Compare November 14, 2024 18:00
@danyx23 danyx23 merged commit bf8b333 into master Nov 14, 2024
5 of 16 checks passed
@danyx23 danyx23 deleted the fix-explorer-edit-link branch November 14, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit option for explorers redirects to a broken link
3 participants