Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: add link to author page in article header #3626

Closed
wants to merge 1 commit into from

Conversation

mlbrgl
Copy link
Member

@mlbrgl mlbrgl commented May 21, 2024

⚠️ This is a PoC, do not merge.

Adds a link to author pages in the byline of articles.

Copy link
Member Author

mlbrgl commented May 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mlbrgl and the rest of your teammates on Graphite Graphite

@mlbrgl
Copy link
Member Author

mlbrgl commented May 21, 2024

Discussed during site dev meeting on May 21:

  • ✅ do not add to post_links table for now
  • ✅ do not create a separate entity, table for authors. Source of truth remains the author gdocs.
  • ⏳ decouple from linkedDocuments, and use an additional attachment.

@ikesau
Copy link
Member

ikesau commented May 21, 2024

Not necessarily part of this branch but just thought that we'll want to have authors' names be clickable in

as well :]

@mlbrgl
Copy link
Member Author

mlbrgl commented May 22, 2024

@ikesau yep, I agree. There are a bunch of places we had in mind but decided to introduce those links gradually. As you pointed out, we'll work on those in separate PRs.

(closing this one in favor of #3633 due to a messy rebase saved by reflog 🥵)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants