Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (timeline) show current time point correctly #3494

Merged
merged 1 commit into from
May 20, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Apr 15, 2024

  • Fixes an issue where the current start or end point wasn't in sync with the timeline handle
  • To reproduce:
Screenshot 2024-04-15 at 14 21 13

Copy link
Member Author

sophiamersmann commented Apr 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented May 1, 2024

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label May 1, 2024
@github-actions github-actions bot closed this May 5, 2024
@marcelgerber marcelgerber reopened this May 6, 2024
Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@owidbot
Copy link
Contributor

owidbot commented May 13, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-timeline-current-time

SVG tester:

Number of differences (default views): 0
Number of differences (all views): 70 (98d046)

Edited: 2024-05-20 08:25:33 UTC
Execution time: 1.24 seconds

@sophiamersmann sophiamersmann force-pushed the table-timeline branch 4 times, most recently from c9935d3 to c9bb665 Compare May 15, 2024 15:30
@sophiamersmann sophiamersmann force-pushed the timeline-current-time branch from 5b43b36 to d145eba Compare May 15, 2024 15:30
@sophiamersmann sophiamersmann marked this pull request as ready for review May 15, 2024 15:30
Base automatically changed from table-timeline to master May 20, 2024 08:12
@sophiamersmann sophiamersmann force-pushed the timeline-current-time branch from d145eba to 758f5ce Compare May 20, 2024 08:13
@sophiamersmann sophiamersmann merged commit a6c2c53 into master May 20, 2024
22 of 26 checks passed
@sophiamersmann sophiamersmann deleted the timeline-current-time branch May 20, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants