-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 (timeline) show current time point correctly #3494
Conversation
sophiamersmann
commented
Apr 15, 2024
•
edited
Loading
edited
- Fixes an issue where the current start or end point wasn't in sync with the timeline handle
- To reproduce:
- Go to https://ourworldindata.org/grapher/life-expectancy-at-different-ages
- Go to the table tab and move the start timeline handle a bit to the right
- Go back to the chart tab and hover over the timeline's start handle
- Note that the current time displayed in the tooltip isn't the actual time that is used for plotting (see screenshot)
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite |
ce34f6f
to
fff5caf
Compare
58e9ac3
to
7566184
Compare
fff5caf
to
e3281fc
Compare
7566184
to
47a6678
Compare
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix!
e3281fc
to
667805c
Compare
47a6678
to
d4233e3
Compare
667805c
to
584b3dc
Compare
d4233e3
to
ed2e12e
Compare
584b3dc
to
bc8a37f
Compare
eaae9dd
to
37f0b44
Compare
dae3bee
to
7ff9e9f
Compare
37f0b44
to
9c34b4c
Compare
7ff9e9f
to
c4917ba
Compare
9c34b4c
to
5b43b36
Compare
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 Edited: 2024-05-20 08:25:33 UTC |
c9935d3
to
c9bb665
Compare
5b43b36
to
d145eba
Compare
d145eba
to
758f5ce
Compare