🐛 (grapher) show timeline on table tab if necessary

[sophiamersmann]

• fixes Grapher's data table sometimes doesn't show all plotted data #3174

Summary

• Stacked area and bar charts as well as line charts show multiple years at once (since time is plotted on the x-axis)
• If the timeline is hidden, the chart thus shows the whole range of data points (all values from start time to end time), but the table only shows data points for the start and end time exclusively
• This PR makes it so that the timeline is always shown on the table tab for stacked bar/area and line charts
• Datasette: Stacked area/bar and line charts where the timeline is hidden

Data cleanup

• http://staging-site-table-timeline/grapher/natural-disasters-by-type: Set timelineMinTime and timelineMaxTime to what's currently set as minTime and maxTime so that we don't include data in the table that is not plotted
• Turn these two charts into "proper" discrete bar charts (they're line charts under the hood)
  • http://staging-site-table-timeline/grapher/covid-tests-per-confirmed-case-exemplars
  • http://staging-site-table-timeline/grapher/share-of-global-consumption-based-co-emissions-and-population

[sophiamersmann]

• 🐛 (timeline) show current time point correctly #3494
• 🐛 (grapher) show timeline on table tab if necessary #3458 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

[marcelgerber]

Hm, what's super weird about this is that changing the timeline selection on the table tab changes what's shown on the chart tab - but then back on the chart tab, there's no way to "go back" to the initial timeline selection.

Assuming that the decision to hide the timeline has been made consciously, this shouldn't be possible.

[sophiamersmann]

I'm not sure what you mean. Do you have an example chart?

[marcelgerber]

I think it's gonna be everyone? See the video (in there, it's http://staging-site-table-timeline/grapher/natural-disasters-by-type).

CleanShot.2024-04-09.at.12.14.44.mp4

[sophiamersmann]

Ah, now I know what you mean. Hmm..

[github-actions]

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

[marcelgerber]

Sorry for the late review, this makes sense to me now. Great!

[owidbot]

Quick links (staging server):

Site	Admin	Wizard

Login: ssh owid@staging-site-table-timeline

• Site-screenshots: https://github.com/owid/site-screenshots/compare/table-timeline
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/table-timeline

SVG tester:

Number of differences (default views): 0
Number of differences (all views): 70 (8f99ef)

Edited: 2024-05-15 15:46:53 UTC
Execution time: 1.34 seconds

[sophiamersmann]

Hey @marcelgerber, thanks for the review! There was another bug here where a line chart turned into a discrete bar chart when you dragged the handles onto the same year on the table tab. I updated the isLineChartThatTurnedIntoDiscreteBar to fix this. Can you have a quick look to see if that makes sense to you? 😇

[marcelgerber]

Good on you for catching that case! 🙌🏻