Skip to content

Commit

Permalink
🖊️ Add some notes for image resizing refactoring from the retro
Browse files Browse the repository at this point in the history
  • Loading branch information
danyx23 committed Feb 29, 2024
1 parent 5d6ff28 commit 8249d7a
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions baker/GDriveImagesBaker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@ export const bakeDriveImages = async (bakedSiteDir: string) => {

const imagesDirectory = path.join(bakedSiteDir, "images", "published")

// TODO 2024-02-29: In the retrospective about a recent resized image bug in prod we
// discussed a few improvements to make to this code:
// - [ ] Add etags for all the resizes so that we are checking if all
// the sizes are up to date, not just the original image.
// - [ ] Clarify the filenames of the paths involved so that it is clear
// what refers to the original image, the local version, ...
// - [ ] Break this function into smaller functions to make it easier to
// understand and maintain.

// If this causes timeout errors, try decreasing concurrency (2 should be safe)
await pMap(
images,
Expand Down

0 comments on commit 8249d7a

Please sign in to comment.