From b9998ff29a6d2e7b8c44d0d464cdd246177fc95a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Lesimple?=
 <stephane.lesimple+bastion@ovhcloud.com>
Date: Tue, 10 Dec 2024 10:29:54 +0000
Subject: [PATCH] fix: scp: downloads would sometimes stall (#486)

---
 bin/plugin/open/scp      | 14 ++++++--------
 bin/plugin/open/scp.json |  2 +-
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/bin/plugin/open/scp b/bin/plugin/open/scp
index 390ddeab4..a54c716c1 100755
--- a/bin/plugin/open/scp
+++ b/bin/plugin/open/scp
@@ -311,8 +311,8 @@ $fnret or osh_exit($fnret);
 
 my $machine = $fnret->value->{'machine'};
 my @keys    = @{$fnret->value->{'keys'} || []};
-# now build the command
 
+# now build the command
 my @cmd = qw{ ssh -x -oForwardAgent=no -oPermitLocalCommand=no -oClearAllForwardings=yes };
 push @cmd, ('-p', $port) if $port;
 push @cmd, ('-l', $user) if $user;
@@ -327,20 +327,18 @@ print STDERR ">>> Hello $self, transferring your file through the bastion "
   . ($protocol eq 'scpupload' ? 'to' : 'from')
   . " $machine...\n";
 
-#print STDERR join('^', @cmd)."\n";
-$fnret = OVH::Bastion::execute(cmd => \@cmd, expects_stdin => 1, is_binary => 1);
+# Use system here and in plugin's json config to avoid buffering deadlock issues (#486)
+$fnret = OVH::Bastion::execute(cmd => \@cmd, system => 1);
 if ($fnret->err ne 'OK') {
     osh_exit 'ERR_TRANSFER_FAILED', "Error launching transfer: $fnret";
 }
-print STDERR sprintf(
-    ">>> Done, %d bytes uploaded, %d bytes downloaded\n",
-    $fnret->value->{'bytesnb'}{'stdin'} + 0,
-    $fnret->value->{'bytesnb'}{'stdout'} + 0
-);
 
 if ($fnret->value->{'sysret'} != 0) {
     print STDERR ">>> On bastion side, scp exited with return code " . $fnret->value->{'sysret'} . ".\n";
 }
+else {
+    print STDERR ">>> Done, scp exited successfully.\n";
+}
 
 # don't use osh_exit() to avoid getting a footer
 exit OVH::Bastion::EXIT_OK;
diff --git a/bin/plugin/open/scp.json b/bin/plugin/open/scp.json
index 4b509ecc0..9376ff101 100644
--- a/bin/plugin/open/scp.json
+++ b/bin/plugin/open/scp.json
@@ -1,5 +1,5 @@
 {
-    "execution_mode": "binary",
+    "execution_mode": "system",
     "stealth_stdout": true,
     "jit_mfa": "token",
     "jit_mfa_allow_no_host": true,