Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process response time taken is all over the place #54

Closed
dylanratcliffe opened this issue Feb 28, 2023 · 1 comment
Closed

Process response time taken is all over the place #54

dylanratcliffe opened this issue Feb 28, 2023 · 1 comment
Assignees
@dylanratcliffe
Labels
bug Something isn't working

Comments

@dylanratcliffe
Copy link
Member

I'm seeing in the traces that the ProcessResponse traces is always taking almost exactly 100ms. This doesn't seem right as it's far too consistent to be anything other than a wait, but I don't think this should be waiting for anything.

I'm seeing many times it takes less than 0.01ms and other where it takes ~100ms, and nothing inbetween

e.g. https://ui.honeycomb.io/overmind/environments/prod/datasets/gateway/result/nNqnRyNB5Fe/trace/jhdgeU74VN8?fields[]=c_name&fields[]=c_service.name&span=628a6b7705ee7069
@dylanratcliffe dylanratcliffe self-assigned this Feb 28, 2023
@dylanratcliffe dylanratcliffe added the bug Something isn't working label Feb 28, 2023
@dylanratcliffe
Copy link
Member Author

This is due to the DrainDelay setting: https://github.com/overmindtech/sdp-go/blob/main/progress.go#L706-L717

It can be removed once overmindtech/sdp#29 is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dylanratcliffe dylanratcliffe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dylanratcliffe