Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing currency variables to inflation adjustment #59

Open
1 of 2 tasks
knaaptime opened this issue Feb 28, 2019 · 4 comments
Open
1 of 2 tasks

add missing currency variables to inflation adjustment #59

knaaptime opened this issue Feb 28, 2019 · 4 comments
Labels
data related to data layer good first issue Good for newcomers
Milestone

Comments

@knaaptime
Copy link
Member

knaaptime commented Feb 28, 2019

  • ltdb reader
  • ncdb reader
@knaaptime knaaptime added this to the release 0.1.0 milestone Aug 22, 2019
@knaaptime knaaptime added data related to data layer good first issue Good for newcomers labels Aug 22, 2019
@JennEYoon
Copy link

I would like to tackle this, but would need more guidance on what is desired.

Am I to edit "geosnap/data/variables.csv" file? I see under the column "ltdb" various nationalities.

Or is "inflation adjustment" a function or class method defined in a code segment?

Do you have a guide for first time contributors to the geosnap project? Thanks. Hopefully I can add some value.

Footer: Issue #59 -- Add Missing Currency Variables to Inflation Adjustment.

@knaaptime
Copy link
Member Author

awesome, thanks @JennEYoon! we dont have a contributor guide yet, thanks for raising that.

Here are the details on this issue:

we have a function that converts currency variables for inflation. When a user stores a longitudinal dataset like LTDB or NCDB in geosnap's database, the function that reads in the data sends the appropriate columns to the inflation adjuster function. Here is what that looks like for the LTDB reader. Notice that the columns in the list match the currency variables in the ltdb column of variables.csv. What still needs to be done are two things:

  1. verify that the columns in inflate_cols on line 494 are all the currency variables in LTDB. This would mean going through each of the rows of variables.csv and looking for those variables that represent currency of some kind and making sure each one is listed in inflate_cols.
  2. copy logic similar to lines 494-509 into the store_ncdb function, but making sure that the inflate_cols in this case match the currency variables from the ncdb column in variables.csv

@JennEYoon
Copy link

Thanks! I will get on it.

@JennEYoon
Copy link

Dear Eli @knaaptime ,
PR ready for your review, Issue #59 Inflation Adjustment.
Sorry it took so long.

@knaaptime knaaptime mentioned this issue Nov 18, 2019
5 tasks
@knaaptime knaaptime mentioned this issue Nov 27, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data related to data layer good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants