Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: output for offline users in !user command is confusing #637

Open
cmyui opened this issue Feb 26, 2024 · 1 comment
Open

bug: output for offline users in !user command is confusing #637

cmyui opened this issue Feb 26, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@cmyui
Copy link
Member

cmyui commented Feb 26, 2024

When using the command with an offline user, the "logged in" and "last server interaction" are the time since 1970. We should make these more user-friendly -- and e.g. show "User not online".

22:28 cmyui: !user tsunyoku
22:28 Aika: [Player] tsunyoku (224)
Privileges: ['VERIFIED', 'UNRESTRICTED']
Donator: False
Channels: []
Logged in: 54 years ago
Last server interaction: 54 years ago
osu! build: Unknown | Tourney: False
Silenced: False | Spectating: None
Last /np: None
Recent score: None
Match: None
Spectators: [] | Elapsed: 3.41 msec
@cmyui cmyui added documentation Improvements or additions to documentation good first issue Good for newcomers bug Something isn't working and removed documentation Improvements or additions to documentation labels Feb 26, 2024
@cmyui
Copy link
Member Author

cmyui commented Feb 26, 2024

There's also a column in the users table -- latest_activity. We could use this to display the latest activity, without the user needing to be online. This can be fetched using the users_repo.fetch_one method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant