Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building the tool #38

Open
soveran opened this issue Dec 10, 2015 · 3 comments
Open

Building the tool #38

soveran opened this issue Dec 10, 2015 · 3 comments

Comments

@soveran
Copy link

soveran commented Dec 10, 2015

I'm using this makefile:

y.output:
    go tool yacc -o src/comp/y.go -p "comp_" src/comp/grammar.y

test: comp
    go test comp

comp: y.output
    go build ./src/comp

I think it may be useful to have it in the repo. Regardless, I think the go build ./src/comp step is missing in the README. I can submit a pull request either for adding that step to the README, or to provide a makefile with the corresponding modifications to the README.

@ostap
Copy link
Owner

ostap commented Dec 10, 2015

It has been a while since I last looked at it. From what I understand, go tools evolved and the whole step of changing the GOPATH can be eliminated. This, however, involves changing the commands above:

$ echo $GOPATH
/home/ostap/gopath
$ pwd
/home/ostap/comp
$ go tool yacc -o src/comp/y.go -p "comp_" src/comp/grammar.y
$ go build -o comp src/comp/*.go
$ go test src/comp/*.go

I will gladly accept a pull request with the Makefile and a README update.

@soveran
Copy link
Author

soveran commented Dec 10, 2015

The tests don't pass for me, but I will send you the PR anyway so you can check what could be happening.

@ostap
Copy link
Owner

ostap commented Dec 10, 2015

Indeed. It is related to #26. I temporarily disabled the tests which reproduce the issue.

ostap pushed a commit that referenced this issue Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants