Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an efficient way to advise contributors about opening an issue first before making a PR #12

Open
exitflynn opened this issue Jan 8, 2024 · 2 comments
Labels
discussion requires discussion on what the solution can look like good first issue Good for newcomers help wanted Extra attention is needed

Comments

@exitflynn
Copy link
Member

It's usually a good practice to open an issue first and then make a PR addressing it since it gives some time and opportunity for people to discuss if a change is worth adding before starting work on it, which can save efforts.

We should add that as a guideline somewhere (this could apply for all OSDC projects), though I'm not sure what the best way would be, maybe PR templates that say something to the effect of 'we recommend you open an issue first'?

@exitflynn exitflynn added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 8, 2024
@Kenny4297
Copy link

Hi @exitflynn, I believe I can help with this issue. Would you mind assigning me to it?

@exitflynn
Copy link
Member Author

hey @Kenny4297, apologies for the late response and thanks for the interest! I believe this would require a little research / discussion on what alternatives we can use here beforehand.

(I didn't plan on being recursive 😭 but) Can you add any ideas you might have of how to implement this before starting work on it? It'd give a chance for people to add suggestions.

We should have a discussion tag here. 😎

@exitflynn exitflynn added the discussion requires discussion on what the solution can look like label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion requires discussion on what the solution can look like good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants