fix(vfs): race condition on temp file cleanup #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maryam4s26 could you try this PR and checks if this fixes your errors in os-js/OS.js#840 ? |
There was a race condition relating to streams in the VFS pipeline that could lead to unhandled rejection whenever a cleanup is performed on an endpoint with pre-check errors (like readonly).
andersevenrud
force-pushed
the
fix/on-done-race-condition
branch
from
ff816d2 to
c1f9c2b
Compare
hi @andersevenrud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition relating to streams in the VFS pipeline that could lead to unhandled rejection whenever a cleanup is performed on an endpoint with pre-check errors (like readonly).
Fixes os-js/OS.js#840