Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing the osjs when uploading a file in dynamic mountpoints that not found #87

Closed
maryam4s26 opened this issue Jan 9, 2024 · 8 comments
Labels
bug Something isn't working question Further information is requested

Comments

@maryam4s26
Copy link

hi @andersevenrud .

When the server is restarted, the dynamic mountpoints will be deleted from the server.
And the client doesn't notice this change.

If the user clicks on the mountpoints, gets a 403 error:
image

image

But if the user uploads a file in the mountpoint client at the same time when mountpoint is not on the server, the server will crash:
image

image

@andersevenrud
Copy link
Member

When the server is restarted, the dynamic mountpoints will be deleted from the server.
And the client doesn't notice this change.

Maybe you can recover from this ? Like having the service where you set up these mountpoint store the current state somewhere, and this is loaded when the service starts up ?

@maryam4s26
Copy link
Author

thank you @andersevenrud.

I have used this here as well and it has not crashed
Do you think this solution is wrong?

@andersevenrud
Copy link
Member

Try this instead: #88

@maryam4s26
Copy link
Author

Thank you very much.
I have tested this and it solved my problem.

@andersevenrud
Copy link
Member

andersevenrud commented Jan 9, 2024

Excellent! I really should have seen that edge case when I worked on the previous fix... but at least now I think we have every hole patched up. Thanks for all the reports!

I published a new version with the patch.

Can this issue be closed now ? It was kind of a discovery and a bug combined, and I'm not sure if my response to the mountpoint stuff answered your needs 😅

@maryam4s26
Copy link
Author

Thank you @andersevenrud .
Yes, your answer has completely solved my problem.

@andersevenrud andersevenrud added bug Something isn't working question Further information is requested labels Jan 9, 2024
@maryam4s26
Copy link
Author

I am impatiently waiting for your patch version update. @andersevenrud.

@andersevenrud
Copy link
Member

Oh... I forgot to push my changes to github and only published to npm. Repo has been updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants