Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unzip option for zip files #39

Open
valp124 opened this issue Jul 28, 2022 · 8 comments
Open

Unzip option for zip files #39

valp124 opened this issue Jul 28, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@valp124
Copy link

valp124 commented Jul 28, 2022

#30 mentions handling zip files as regular folders. How about this instead (or in addition): a right-click (and/or) menu option to unzip a zip file? Similar to the 7-zip menu:

image

(but just one button, "unzip," meaning "unzip in place" would be totally sufficient)

Thank you so much!

@andersevenrud
Copy link
Member

Hey!

This would indeed be a great feature! And should not be that hard 🤔 The best way to solve this is to add a new method to the VFS API called archive or something that could inflate/deflate etc. based on filename.

os-js/OS.js#804 would help out a great deal with this so that this feature could be enabled only for filesystems that supports it (which would be the OS.js server by default).

@andersevenrud andersevenrud added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 28, 2022
@andersevenrud
Copy link
Member

@ajmeese7 you might find this interesting :)

@ajmeese7
Copy link
Member

I'd be happy to give this a go! Can't promise a timeline since I'm working on several other features at the moment, but I think this is a great idea that I would also like to see implemented. Feel free to assign it to me if you'd like @andersevenrud

@ajmeese7
Copy link
Member

@andersevenrud at least until we fully have the "Select all" feature implemented on the file manager, I think it would be best to have an unarchive or extract method or something similar to indicate that it is only meant to be used in one direction. Unless you want support for compressing a single file, in which case I'm fine with the archive approach that you suggested. What are your thoughts?

@andersevenrud
Copy link
Member

andersevenrud commented Jul 29, 2022

The idea was just to start with support for doing extraction of single archives.

And all of archive interaction could be done with a single endpoint, i.e:

archive(archiveFile, { action: 'extract', destination: somewhere })
archive(archiveFile, { action: 'compact', files: [otherFile, ...] })
archive(archiveFile, { action: 'empty' })
archive(archiveFile, { action: 'info' })

The "select all" feature will just make it possible to do the compacting thing.

@ajmeese7 ajmeese7 moved this to 🏗 In progress in @ajmeese7's backlog Jul 29, 2022
@ajmeese7
Copy link
Member

I finished implementing this for the most part a few days ago, I just need to make sure the multiselect PR's are merged before I finish up and make a PR. I have multiselect locally so I designed the archive feature with that in mind :)

@ajmeese7
Copy link
Member

This is completely done on my end, with the exception of tests. My tests are being incredibly wonky and everything with them seems to just have randomly broken, but as soon as I can get those figured out and passing again I will make the PR!

@ajmeese7 ajmeese7 moved this from 🏗 In progress to 👀 In review in @ajmeese7's backlog Aug 15, 2022
@ajmeese7 ajmeese7 moved this from 👀 In review to 🏗 In progress in @ajmeese7's backlog Aug 15, 2022
@valp124
Copy link
Author

valp124 commented Mar 22, 2023

How's it going with this, folks? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants