From d3c3627b6b1db47c8beeb9b466afb1f68d25a54f Mon Sep 17 00:00:00 2001 From: Oliver Kurz Date: Wed, 7 Feb 2024 16:48:47 +0100 Subject: [PATCH] Provide Makefile targets for additional checks Having all usual checks available over the Makefile makes it easier for developers to see what is available and call them. --- .github/workflows/perl-critic.yml | 2 +- .github/workflows/perl-lint-checks.yml | 2 +- .github/workflows/yamllint.yml | 4 ++-- Makefile | 10 +++++++++- 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/.github/workflows/perl-critic.yml b/.github/workflows/perl-critic.yml index 92cbcfc..840be05 100644 --- a/.github/workflows/perl-critic.yml +++ b/.github/workflows/perl-critic.yml @@ -11,4 +11,4 @@ jobs: image: perldocker/perl-tester steps: - uses: actions/checkout@v4 - - run: ./tools/perlcritic --quiet . + - run: make test-critic diff --git a/.github/workflows/perl-lint-checks.yml b/.github/workflows/perl-lint-checks.yml index 1808526..73d4d5e 100644 --- a/.github/workflows/perl-lint-checks.yml +++ b/.github/workflows/perl-lint-checks.yml @@ -11,4 +11,4 @@ jobs: image: registry.opensuse.org/devel/openqa/containers/os-autoinst_dev steps: - uses: actions/checkout@v4 - - run: GITHUB_ACTIONS=1 ./tools/tidyall --check-only --all --quiet + - run: GITHUB_ACTIONS=1 make test-tidy diff --git a/.github/workflows/yamllint.yml b/.github/workflows/yamllint.yml index 64d6b94..246cd75 100644 --- a/.github/workflows/yamllint.yml +++ b/.github/workflows/yamllint.yml @@ -11,5 +11,5 @@ jobs: - uses: actions/checkout@v4 - uses: docker://registry.opensuse.org/home/okurz/container/containers/tumbleweed:yamllint with: - entrypoint: yamllint - args: -c .yamllint --strict ./ --format github + entrypoint: make + args: test-yaml diff --git a/Makefile b/Makefile index c22489f..37e0d26 100644 --- a/Makefile +++ b/Makefile @@ -8,12 +8,20 @@ update-deps: tools/update-deps --cpanfile cpanfile .PHONY: test -test: test-tidy test-author +test: test-tidy test-critic test-yaml test-author .PHONY: test-tidy test-tidy: tools/tidyall --all --check-only +.PHONY: test-critic +test-critic: + tools/perlcritic --quiet . + +.PHONY: test-yaml +test-yaml: + yamllint --strict ./ + .PHONY: test-author test-author: prove -l -r xt/