-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOEM for ROS 2.0 #20
Comments
This would be beneficial, I agree. Thus, I cannot judge what effort a "port" to colcon would be. I'm assuming this would require a separate branch with separate build instructions, doubling maintenance effort. That being said: if someone is willing to invest the time in a colcon port, I'll be happy to investigate any outcomes and track/support this in this repo. Also, I'll be happy to share any maintenance for this repository, if someone is willing to invest his time. This, please reply to this issue if you want to start working on a colcon port. |
I understand. Currently I'm not able to develop a SOEM ROS2 package and I won't have the possibility to do it in the future. I hope that someone else could develop it soon. Thank you. |
Hi, |
@JensLepers I don't have any ROS2 setup, so I cannot do this at this point of time (and also probably not in the next few months). Again, any help here is appreciated... |
I have a ROS2 setup and I am wondering how much work it would be to make the change. Can I assume that I only need to change the CMakeList? (use colcon to build the packages). Or am I completely underestimating this ? |
@jLepers, sorry for the late reply (christmas holdays, etc...). Happy new year. As this is a very simple wrapper, in theory only the Checking the migration guide actually says for the For the build system / <!-- <buildtool_depend>catkin</buildtool_depend> -->
<buildtool_depend>ament_cmake</buildtool_depend> I'd be happy to except PRs to a ROS2 branch, but as long as I cannot test is, the work would need to be done by someone else. |
I made a ROS2 wrapper for SOEM and I can share it if you want. Actually think about making a another package which is using the SOEM-package. So people have an example of how to use it in ROS2 (in my case with some beckhoff I/O). I can share it publicly on bitbucket if there is a demand for it. Got something working now in a ROS2 C++node where the connection is nicely terminated in the destructor of the node. I made one general header-file that is to be used in the application-package so it only needs one include: "soem/soem.h" |
@edhage Sharing what you have would be great. I'm not sure what you suggest, though. Do you want to add it to this package or create a new one? Any examples would be great, though. |
@mgruhler So I made two repositories. https://bitbucket.org/edhage/soem_ros2 for the ROS2 package. Please look at it, and integrate it in your package if you want. If that is done I could remove this repository (no point in keeping doubles). Another repository is a working example, https://bitbucket.org/edhage/ether_ros2, that uses soem_ros2. So if I put both in a workspace and build ("colcon build") than both packages build in the right order (soem_ros2 first) and I can use it directly. |
this is a forked working version for Foxy on 20.04 with just some changes to CMakeLists.txt and package.xml |
@cplasberg thanks. This looks nice. I still haven't gotten around to set up a ROS2 system. But if this is working, I'd be happy to integrate this. |
Sorry for my late response. I think I could do that. |
Also see https://github.com/gborghesan/soem |
Hi,
is a future release of SOEM for ROS 2 (Crystal or Dashing Diademata) expected?
I'm getting familiar with ROS 2 and I think that a SOEM release for it it would be useful.
Thank you.
The text was updated successfully, but these errors were encountered: