Now move method returns a future. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most changes are in Kernel. This solution uses a semaphore to minimize modifications to the code but a more async solution should be possible.
|
I assumed a synchronous API was acceptable here, because the application runs a single bot, and it's ok to block a single thread. |
|
Yes, I understand. I was also disappointed to have to introduce a semaphore. I'll look for a solution without semaphores (most likely with the type of ExecutionEnvironment used for testing) and update this PR. (When you say "a synchronous solution here" do you mean to use an Await construct...?) |
|
I mean that the function doesn't return a Future. |
|
OK, I updated it, let me know what you think. |
| @@ -65,7 +69,7 @@ object Main { | |||
| def step(server: Server, input: Input) { | |||
| if (!input.game.finished) { | |||
| print(".") | |||
| step(server, server.move(input.playUrl, bot move input)) | |||
| step(server, server.move(input.playUrl, Await.result(bot move input, 60.minutes))) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes are in Kernel. This solution uses a semaphore to minimize
modifications to the code but a more async solution should be possible.
Closes #3.