Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up custom code in Vagrantfile #47

Open
patcon opened this issue Sep 16, 2012 · 5 comments
Open

Clean up custom code in Vagrantfile #47

patcon opened this issue Sep 16, 2012 · 5 comments

Comments

@patcon
Copy link
Contributor

patcon commented Sep 16, 2012

Code Climate only evaluates proper modules and classes. The current code sucks at that. Needs to be cleaned up and moved into lib/ dir.


Original post

I'd like myself and everyone else to confront how bad my ruby can be, in the hopes that it will shame me into getting better.

Code Climate is a little like Travis CI, but for grading your coding style for each file via static analysis, and telling you when code gets better or worse with each commit

Just signed up: https://codeclimate.com/github/myplanetdigital/ariadne

Will add badge later

@patcon
Copy link
Contributor Author

patcon commented Sep 16, 2012

Rats. Apparently it only scans app/ and lib/ dirs for files to grade, so unless I convert this into a gem, no dice.

Hey @brynary, I came across you being just generally awesome in this thread: ryanb/cancan#676

Any chance that codeclimate might be getting some like .travis.yml to customize things like setting file patterns?

patcon added a commit that referenced this issue Sep 16, 2012
…dorsements). Added blank travis file [GH-48]. Added contributor section to README.
@brynary
Copy link

brynary commented Sep 16, 2012

Hello!

Code Climate used to only do app/ and lib/, but now tries to find all Ruby files it doesn't think are config files or tests. The code must be defined inside classes or modules, however.

Does this get you what you need?

-Bryan

@patcon
Copy link
Contributor Author

patcon commented Sep 16, 2012

That's totally useful! Thanks man! Will investigate why it's not picking up the very little code that meets that criteria :)

@patcon
Copy link
Contributor Author

patcon commented Sep 18, 2012

TODO on this might as well involve removing all the hacky stuff in Vagrantfile, making it pretty, and putting it in lib/ (even if CodeClimate doesn't explicitly need it)

@patcon
Copy link
Contributor Author

patcon commented Sep 20, 2012

Sahweet. It's picking stuff up now, so more incentive to do this :)
https://codeclimate.com/github/myplanetdigital/ariadne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants