Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alb): Add vitual service loadbalancer #862

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(alb): Add vitual service loadbalancer #862

wants to merge 2 commits into from

Conversation

dmicheneau
Copy link
Member

@dmicheneau dmicheneau commented Dec 2, 2024 •
edited
Loading

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

--- PASS: TestAccALBVirtualServiceResource (151.69s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  152.217s

--- PASS: TestAccALBVirtualServiceDataSource (50.81s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  51.328s

@dmicheneau dmicheneau requested a review from a team as a code owner December 2, 2024 17:21
@dmicheneau dmicheneau linked an issue Dec 2, 2024 that may be closed by this pull request
Add feature LoadBalancer #835
Open
@cloudavenue-bot
Copy link

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@dmicheneau dmicheneau force-pushed the 835-add-feature-loadbalancer branch 2 times, most recently from 705e652 to ec1c2a3 Compare December 2, 2024 21:14
azrod
azrod requested changes Dec 2, 2024
View reviewed changes
examples/resources/cloudavenue_alb_virtual_service/import.sh Outdated Show resolved Hide resolved
internal/provider/alb/virtual_service_schema.go Outdated Show resolved Hide resolved
internal/provider/alb/virtual_service_schema.go Outdated Show resolved Hide resolved
internal/provider/alb/virtual_service_schema.go Outdated Show resolved Hide resolved
internal/provider/alb/virtual_service_schema.go Outdated Show resolved Hide resolved
docs/data-sources/alb_virtual_service.md Outdated Show resolved Hide resolved
docs/data-sources/alb_virtual_service.md Show resolved Hide resolved
docs/resources/alb_virtual_service.md Show resolved Hide resolved
internal/provider/alb/virtual_service_datasource.go Outdated Show resolved Hide resolved
internal/provider/alb/virtual_service_datasource.go Outdated Show resolved Hide resolved
azrod
azrod requested changes Dec 3, 2024
View reviewed changes
internal/testsacc/alb_virtual_service_resource_test.go Outdated Show resolved Hide resolved
internal/testsacc/alb_virtual_service_resource_test.go Outdated Show resolved Hide resolved
internal/testsacc/alb_virtual_service_resource_test.go Outdated Show resolved Hide resolved
internal/testsacc/alb_virtual_service_resource_test.go Show resolved Hide resolved
internal/testsacc/alb_virtual_service_resource_test.go Show resolved Hide resolved
internal/testsacc/alb_virtual_service_resource_test.go Outdated Show resolved Hide resolved
internal/testsacc/alb_virtual_service_resource_test.go Outdated Show resolved Hide resolved
internal/testsacc/alb_virtual_service_resource_test.go Outdated Show resolved Hide resolved
internal/testsacc/alb_virtual_service_resource_test.go Outdated Show resolved Hide resolved
azrod and others added 2 commits December 11, 2024 10:46
@azrod
chore: cleanup vdc common (#837)
3849665
feat: Add resource cloudavenue_alb_virtual_service
ed3c653 
chore: enhancement testacc

feat: Add datasource `cloudavenue_alb_virtual_service`
@dmicheneau dmicheneau force-pushed the 835-add-feature-loadbalancer branch from ec1c2a3 to ed3c653 Compare December 11, 2024 09:52
azrod
azrod requested changes Dec 11, 2024
View reviewed changes
internal/provider/alb/virtual_service_resource.go Show resolved Hide resolved
internal/provider/alb/virtual_service_resource.go Show resolved Hide resolved
internal/provider/alb/virtual_service_resource.go Show resolved Hide resolved
internal/provider/alb/virtual_service_resource.go Show resolved Hide resolved
internal/provider/alb/virtual_service_resource.go Show resolved Hide resolved
internal/provider/alb/virtual_service_types.go Show resolved Hide resolved
internal/testsacc/alb_virtual_service_resource_test.go Show resolved Hide resolved
pkg/uuid/uuid.go Show resolved Hide resolved
.changelog/862.txt Show resolved Hide resolved
.changelog/862.txt Show resolved Hide resolved
@azrod azrod marked this pull request as draft January 6, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azrod azrod azrod requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add feature LoadBalancer
2 participants
@dmicheneau @azrod