V3.1.0 #49
Open
V3.1.0 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
paliwalparitosh
commented
Sep 4, 2023
•
paliwalparitosh
commented
- replaces local helm chart with helm repo - oci-onm
- adds support of OCI livelab
- includes outputs for helm chart commands and created oci resources
- removes helm template input - ociLAEntityID
kgvarun
reviewed
Oct 18, 2023
| - title: "Select an OKE Cluster deployed in this region to start monitoring" | ||
| description: "Use CLI (Helm) if your cluster does not have public API Endpoint or restricted from accessing container-registry.oracle.com. See: https://github.com/oracle-quickstart/oci-kubernetes-monitoring" | ||
| - title: Select an OKE cluster deployed in this region to start monitoring. | ||
| description: "Use CLI (Helm) if your cluster does not have a public API endpoint or if it's restricted from accessing container-registry.oracle.com. See: https://github.com/oracle-quickstart/oci-kubernetes-monitoring" |
There was a problem hiding this comment.
Rephrase to say:
Perquisites: OKE Cluster must have a public API endpoint and can pull image from container-registry.oracle.com. See https://github.com/oracle-quickstart/oci-kubernetes-monitoring for details.
kgvarun
reviewed
Oct 18, 2023
| - title: "OCI Observability & Management Services Configuration" | ||
| description: "See: https://github.com/oracle-quickstart/oci-kubernetes-monitoring for list of resources created" | ||
| - title: "OCI Observability and Management Services Configuration" | ||
| description: "For a list of resources created, see: https://github.com/oracle-quickstart/oci-kubernetes-monitoring" |
There was a problem hiding this comment.
Pls point to a specific doc/readme/section
kgvarun
reviewed
Oct 18, 2023
| # Option to enable/disable metric server installation during helm deployment | ||
| opt_deploy_metric_server: | ||
| type: boolean | ||
| title: Enable Metric Server Installation | ||
| description: Uncheck this if Metric Server is already installed in your cluster. | ||
| title: Enable Metric Server installation |
There was a problem hiding this comment.
Deploy Kubernetes Metric Server
Description: Kubernetes Metrics Server is required for scraping metrics. Select this checkbox if this OKE Cluster doesn't have Kubernetes Metrics Server deployment.
kgvarun
requested changes
Oct 18, 2023
| title: Select compartment for Logging Analytics, Management Agent, and Monitoring service resources | ||
| description: This compartment will be used for creating Dashboards, Log Groups, Entities, Management Agent Keys, Metrics Namespace etc. See https://github.com/oracle-quickstart/oci-kubernetes-monitoring for full list of resources. | ||
| title: Select compartment for Logging Analytics, Management Agent, and Monitoring service resources. | ||
| description: "This compartment will be used for creating dashboards, log groups, entities, Management Agent keys, metric namespaces, and related resources. For a full list of resources, see: https://github.com/oracle-quickstart/oci-kubernetes-monitoring" |
There was a problem hiding this comment.
pls use a specific page for list of resources created.
| default: compartment_ocid | ||
|
|
||
| # Option to create Logging Analytics | ||
| opt_create_new_la_logGroup: # change this to create new log group | ||
| type: boolean | ||
| title: Check if you want to create a new Log Group | ||
| title: Select this check box if you want to create a new log group. |
There was a problem hiding this comment.
we are creating a new log-group for each cluster so this checkbox should be inverted to say "Use existing log group"
| @@ -191,8 +198,8 @@ variables: | |||
| # Option to create Dynamic Group and Policies | |||
| opt_create_dynamicGroup_and_policies: | |||
| type: boolean | |||
| title: Check to create Dynamic Group and Policies required for deploying monitoring solution | |||
| title: Select this check box to create dynamic groups and policies that are required for deploying the monitoring solution. | |||
There was a problem hiding this comment.
link to details of which dynamic groups and policies along w/ corresponding policies
| #description: "Ref: https://github.com/oracle-quickstart/oci-kubernetes-monitoring#pre-requisites" | ||
| description: "Note: The dynamic group definition must be updated, if node pool(s) and OKE Cluster are in different compartments." | ||
| description: "Note: If node pools and the OKE cluster are in different compartments, then the dynamic group definition must be updated." |
There was a problem hiding this comment.
"must be updated..." manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.