feat(idpool): idpool feature for generating id's #400
Conversation
pkg/utils/Idpool.go
Outdated
| _unusedIDs []uint32 // Yet unused IDs in pool Available ids | ||
| _idsInUse map[interface{}]uint32 // Mapping key: id for currently assigned ids | ||
| _idsForReuse map[interface{}]uint32 // Mapping key: id for previously assigned ids | ||
| _refs map[uint32][]interface{} |
There was a problem hiding this comment.
refs sounds like a counter tracking how many times we requested the same id, no?
There was a problem hiding this comment.
correct, its reference to the same id
There was a problem hiding this comment.
then why do we need a slice of slices then? Can we have a slice of counters? map[uint32]uint32?
There was a problem hiding this comment.
actually we need golang type equivalent of 'list' type in python.
we have replaced with "ref map[uint32]map[interface{}]bool"
here the scenario is for same key we can have different references of interface type as reference can be of any type like int, string, alphanumeric etc. that's why we cannot use counter here.
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
3 times, most recently
from
eb45583 to
45ace4d
Compare
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
4 times, most recently
from
ed77db5 to
f0058be
Compare
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
3 times, most recently
from
4d23274 to
63ec07e
Compare
Signed-off-by: Vemula Venkatesh <[email protected]>
Signed-off-by: Vemula Venkatesh <[email protected]>
type changed to list(python) equivalent Signed-off-by: Vemula Venkatesh <[email protected]>
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
from
63ec07e to
a5b9763
Compare
pkg/LinuxGeneralModule/lgm.go
Outdated
| @@ -363,7 +361,12 @@ func Initialize() { | |||
| brTenant = "br-tenant" | |||
| ipMtu = config.GlobalConfig.LinuxFrr.IPMtu | |||
| ctx = context.Background() | |||
| nlink = utils.NewNetlinkWrapperWithArgs(config.GlobalConfig.Tracer) | |||
| RouteTableGen = utils.IDPoolInit("RTtable", routingTableMin, routingTableMax) | |||
There was a problem hiding this comment.
IDPoolInit can just return error if failed to initialize
There was a problem hiding this comment.
added bool return for the initialization status
pkg/LinuxGeneralModule/lgm.go
Outdated
| for { | ||
| routingTable = GenerateRouteTable() | ||
| // var key interface{} | ||
| routingTable, _ = RouteTableGen.GetID(Name, 0) |
There was a problem hiding this comment.
then maybe we could have 2 functions GetID and GetIDWithRef?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
from
3c0dfe3 to
835ccf9
Compare
Signed-off-by: Vemula Venkatesh <[email protected]>
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
from
835ccf9 to
64597cf
Compare
idpool feature for generating id's for mod pointer, routing table id , trie pointer.