feat(evpn): complete fastpath implementation of new arch

[atulpatel261194]

Introducing the complete implementation for fastpath based on the new opi-evpn-br architecture that has been presented to opi-tsc in 15 Feb 2024 link

This PR includes:

• Modular based implementation according to the architecture(feat(evpn): complete fastpath implementation of new arch #384)
• Netlink Watcher (feat(evpn-bridge): netlink watcher Module #385)
• intel e2000 vendor plugin (feat(evpn-bridge): intel e2000 vendor plugin #386)

This PR has dependancy on Netlink Watcher( #385) , Intel Vendor Plugin(#386). Once these 2 PRs ( #385 , #386 ) get merged, We will rebase current PR (#384) to main.
The Current PR (#384) Will be the Last PR to be merged.

[mardim91]

Hello @atulpatel261194 can you please update the description to this one ?

Introducing the complete implementation for fastpath based on the new opi-evpn-br architecture that has been presented to opi-tsc in 15 Feb 2024 link

This PR includes:

Modular based implementation according to the architecture
NetlinkWatcher module
intel e2000 vendor module

[artek-koltun]

My main question, if it is possible to split the PR to smaller chunks to ease the review process. I see that we can at least organize as separate PRs our preparation steps:

• add of DeInit functionality
• some patch to EventBus with subscribe/unsubscribe
• netlink watcher,
• ...
  and finally:
• e2000 plugin

[mardim91]

My main question, if it is possible to split the PR to smaller chunks to ease the review process. I see that we can at least organize as separate PRs our preparation steps:

• add of DeInit functionality
• some patch to EventBus with subscribe/unsubscribe
• netlink watcher,
• ...
  and finally:
• e2000 plugin

Hello @artek-koltun,

The plan that has been presented and agreed by the TSC is to have the two big PRs (drop-0.5 and drop-1.0) first and then for any further development we can make smaller PRs. We have developed the code according that plan. However I understand that it is difficult to review such big PRs in the smallest detail so I think I can discuss with the team to split the drop-1.0 PR in 3 smaller chunks (netlinkWatcher, e2000 plugin and the rest of the code) just to make the review process easier but I cannot go further than that. Of course this will make the testing and bug fixing really hard for us but let me discuss with the team first. If you are ok with that split then maybe we can do it.

[codecov]

Codecov Report

Attention: Patch coverage is 2.15827% with 272 lines in your changes missing coverage. Please review.

Project coverage is 20.29%. Comparing base (5440fb9) to head (3acfb4f).
Report is 34 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/LinuxGeneralModule/lgm.go	0.00%	68 Missing ⚠️
pkg/infradb/infradb.go	0.00%	59 Missing ⚠️
pkg/frr/frr.go	0.00%	45 Missing ⚠️
cmd/main.go	0.00%	43 Missing ⚠️
pkg/utils/helpers.go	0.00%	27 Missing ⚠️
pkg/LinuxCIModule/lci.go	0.00%	17 Missing ⚠️
...g/infradb/subscriberframework/eventbus/eventbus.go	0.00%	13 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #384       +/-   ##
===========================================
- Coverage   50.77%   20.29%   -30.48%     
===========================================
  Files          37       51       +14     
  Lines        2525     6844     +4319     
===========================================
+ Hits         1282     1389      +107     
- Misses       1114     5287     +4173     
- Partials      129      168       +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[glimchb]

no vendor code in OPI, please

[artek-koltun]

Closing this one, as we agreed: no vendor plugins are allowed in generic domain bridges