Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code generator protoc-gen-grpc-gateway hasn't been updated to support optional fields in proto3 #332

Closed
devkevinyy opened this issue Aug 23, 2023 · 2 comments · Fixed by #419
Closed

code generator protoc-gen-grpc-gateway hasn't been updated to support optional fields in proto3 #332

devkevinyy opened this issue Aug 23, 2023 · 2 comments · Fixed by #419
Labels
bug Something isn't working

Comments

@devkevinyy
Copy link
Contributor

devkevinyy commented Aug 23, 2023 •
edited by glimchb
Loading

see grpc-ecosystem/grpc-gateway#1278
see namely/docker-protoc#361

An exception occurs when I use namely/protoc-all:1.51_2 with the parameter: --with-gateway to convert a proto file to a REST service:

... is a proto3 file that contains optional fields, but code generator protoc-gen-grpc-gateway hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.--grpc-gateway_out:
make: *** [Makefile:9: all] Error 1

Would like to update the protoc version in the namely/protoc-all mirror to support this.
@artek-koltun artek-koltun added Storage APIs or code related to storage area and removed Storage APIs or code related to storage area labels Aug 28, 2023
@glimchb glimchb added the bug Something isn't working label Sep 7, 2023
This was referenced Sep 7, 2023
Closed
Open
@glimchb
Copy link
Member

glimchb commented Sep 7, 2023

I tested with cdecoux/protoc-all:1.51_1 and it compiles fine now
waiting on namely/docker-protoc#361

@glimchb
Copy link
Member

glimchb commented Sep 11, 2023 •
edited
Loading

trying to enable grpc gw for inventory #359
draft PR opiproject/opi-smbios-bridge#174

@chujieyang can you please take a look at 174 above ?

@artek-koltun artek-koltun mentioned this issue Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(storage): update to support buf lint and generation automation artek-koltun/opi-api
3 participants
@devkevinyy @glimchb @artek-koltun