Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with logging flag validations #1556

Open
joelanford opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1599
Open

Fix issues with logging flag validations #1556

joelanford opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1599
Assignees
@camilamacedo86

Comments

@joelanford
Copy link
Member

Based on what I found trying to debug the previous sync failures, we need to search for setupLog.Error(nil, <errorString>) and make sure we instead use setupLog.Error(errors.New()). Using nil for the error results in no log line being written. In my case, it meant completely empty pod logs.

See https://github.com/search?q=repo%3Aoperator-framework%2Foperator-controller%20setupLog.Error(nil&type=code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camilamacedo86 camilamacedo86

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@joelanford @camilamacedo86