Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in brave-encoder-stackdriver when local ip is not set #225

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix NPE in brave-encoder-stackdriver when local ip is not set #225

merged 1 commit into from
Aug 15, 2024

Conversation

oswynb
Copy link
Contributor

@oswynb oswynb commented Aug 14, 2024

Closes #224

shakuzen
shakuzen approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@shakuzen shakuzen merged commit 4638532 into openzipkin:master Aug 15, 2024
3 checks passed
@ccudennec-otto ccudennec-otto mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullPointerException when no local ip in Span
2 participants
@oswynb @shakuzen